[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Gnash-commit] gnash ChangeLog server/asobj/Global.cpp testsui...

From: Martin Guy
Subject: Re: [Gnash-commit] gnash ChangeLog server/asobj/Global.cpp testsui...
Date: Thu, 1 Feb 2007 20:37:50 +0000

2007/2/1, strk <address@hidden>:
On Thu, Feb 01, 2007 at 07:35:37PM +0000, Martin Guy wrote:
If you keep the triple slashes after the brief description, the comment
will end up in the "long" description when creating the doxygen page:

/// \brief ...
/// brief desc continues
/// Long description
/// here


> +    assert(fn.nargs == 1);

We use asserts often, but calling _global.excape(any, number, of, args)
is completely legit in ActionScript, so we'd do a better job with something

Yes, there are a lot of asserts around that will make gnash quit on
ill-formed files instead of carrying on as best it can, which make it
easy to write files that play ok in Adobe but will cause gnash to
bomb, which make Gnash look bad. I'll convert them to tests wherever I
see such things. Asserts should test for impossible *internal*
conditions, ie "this can never happen"s

> +    string input = fn.arg(0).to_string();

Note that to_string() might return NULL, in which case
the std::string constructor will segfault.

Wot, even if fn.nargs==1 ?


reply via email to

[Prev in Thread] Current Thread [Next in Thread]