[Gnash-commit] gnash ChangeLog backend/sound_handler_gst.cpp g...

[Sandro Santilli]

CVSROOT:        /sources/gnash
Module name:    gnash
Changes by:     Sandro Santilli <strk>  07/05/02 07:34:35

Modified files:
        .              : ChangeLog 
        backend        : sound_handler_gst.cpp 
        gui            : Player.cpp 
        libamf         : amf.cpp 
        libbase        : log.h 
        server         : as_function.cpp button_character_instance.cpp 
                         character.cpp sprite_instance.cpp 
        server/asobj   : NetStreamGst.cpp 
        server/swf     : tag_loaders.cpp 

Log message:
                * backend/sound_handler_gst.cpp, gui/Player.cpp, libamf/amf.cpp,
                  libbase/log.h, server/as_function.cpp, 
server/swf/tag_loaders.cpp,
                  server/button_character_instance.cpp, server/character.cpp,
                  server/sprite_instance.cpp, server/asobj/NetStreamGst.cpp:
                  Drop log_warning, till we find a semantic for it.

CVSWeb URLs:
http://cvs.savannah.gnu.org/viewcvs/gnash/ChangeLog?cvsroot=gnash&r1=1.3056&r2=1.3057
http://cvs.savannah.gnu.org/viewcvs/gnash/backend/sound_handler_gst.cpp?cvsroot=gnash&r1=1.35&r2=1.36
http://cvs.savannah.gnu.org/viewcvs/gnash/gui/Player.cpp?cvsroot=gnash&r1=1.46&r2=1.47
http://cvs.savannah.gnu.org/viewcvs/gnash/libamf/amf.cpp?cvsroot=gnash&r1=1.34&r2=1.35
http://cvs.savannah.gnu.org/viewcvs/gnash/libbase/log.h?cvsroot=gnash&r1=1.47&r2=1.48
http://cvs.savannah.gnu.org/viewcvs/gnash/server/as_function.cpp?cvsroot=gnash&r1=1.30&r2=1.31
http://cvs.savannah.gnu.org/viewcvs/gnash/server/button_character_instance.cpp?cvsroot=gnash&r1=1.46&r2=1.47
http://cvs.savannah.gnu.org/viewcvs/gnash/server/character.cpp?cvsroot=gnash&r1=1.39&r2=1.40
http://cvs.savannah.gnu.org/viewcvs/gnash/server/sprite_instance.cpp?cvsroot=gnash&r1=1.261&r2=1.262
http://cvs.savannah.gnu.org/viewcvs/gnash/server/asobj/NetStreamGst.cpp?cvsroot=gnash&r1=1.25&r2=1.26
http://cvs.savannah.gnu.org/viewcvs/gnash/server/swf/tag_loaders.cpp?cvsroot=gnash&r1=1.92&r2=1.93

Patches:
Index: ChangeLog
===================================================================
RCS file: /sources/gnash/gnash/ChangeLog,v
retrieving revision 1.3056
retrieving revision 1.3057
diff -u -b -r1.3056 -r1.3057
--- ChangeLog   2 May 2007 06:55:11 -0000       1.3056
+++ ChangeLog   2 May 2007 07:34:34 -0000       1.3057
@@ -1,5 +1,13 @@
 2007-05-02 Sandro Santilli <address@hidden>
 
+       * backend/sound_handler_gst.cpp, gui/Player.cpp, libamf/amf.cpp,
+         libbase/log.h, server/as_function.cpp, server/swf/tag_loaders.cpp,
+         server/button_character_instance.cpp, server/character.cpp,
+         server/sprite_instance.cpp, server/asobj/NetStreamGst.cpp:
+         Drop log_warning, till we find a semantic for it.
+
+2007-05-02 Sandro Santilli <address@hidden>
+
        * server/sprite_instance.cpp (sprite_getBounds): remove TESTING
          warning, I'm pretty confident about this function now.
 

Index: backend/sound_handler_gst.cpp
===================================================================
RCS file: /sources/gnash/gnash/backend/sound_handler_gst.cpp,v
retrieving revision 1.35
retrieving revision 1.36
diff -u -b -r1.35 -r1.36
--- backend/sound_handler_gst.cpp       13 Apr 2007 07:35:55 -0000      1.35
+++ backend/sound_handler_gst.cpp       2 May 2007 07:34:34 -0000       1.36
@@ -18,7 +18,7 @@
 // Based on sound_handler_sdl.cpp by Thatcher Ulrich http://tulrich.com 2003
 // which has been donated to the Public Domain.
 
-/* $Id: sound_handler_gst.cpp,v 1.35 2007/04/13 07:35:55 bjacques Exp $ */
+/* $Id: sound_handler_gst.cpp,v 1.36 2007/05/02 07:34:34 strk Exp $ */
 
 #ifdef HAVE_CONFIG_H
 #include "config.h"
@@ -322,8 +322,10 @@
                gst_element->decoder = gst_element_factory_make ("mad", NULL);
                if (gst_element->decoder == NULL) {
                        gst_element->decoder = gst_element_factory_make 
("flump3dec", NULL);
-                       if (gst_element->decoder != NULL && 
!gst_default_registry_check_feature_version("flump3dec", 0, 10, 4)) {
-                               gnash::log_warning("This version of fluendos 
mp3 plugin does not support flash streaming sounds, please upgrade to version 
0.10.4 or higher.");
+                       if (gst_element->decoder != NULL && 
!gst_default_registry_check_feature_version("flump3dec", 0, 10, 4))
+                       {
+                               // I keep getting these messages even if I hear 
sound... too much paranoia ?
+                               gnash::log_debug("This version of fluendos mp3 
plugin does not support flash streaming sounds, please upgrade to version 
0.10.4 or higher.");
                        }
                }
                // Check if the element was correctly created

Index: gui/Player.cpp
===================================================================
RCS file: /sources/gnash/gnash/gui/Player.cpp,v
retrieving revision 1.46
retrieving revision 1.47
diff -u -b -r1.46 -r1.47
--- gui/Player.cpp      18 Apr 2007 09:35:41 -0000      1.46
+++ gui/Player.cpp      2 May 2007 07:34:34 -0000       1.47
@@ -325,7 +325,7 @@
        }
 
        // too much noise...
-        //log_warning(_("Unused parameter %s = %s"),
+        //log_debug(_("Unused parameter %s = %s"),
        //      it->first.c_str(), it->second.c_str());
     }
 

Index: libamf/amf.cpp
===================================================================
RCS file: /sources/gnash/gnash/libamf/amf.cpp,v
retrieving revision 1.34
retrieving revision 1.35
diff -u -b -r1.34 -r1.35
--- libamf/amf.cpp      30 Apr 2007 17:24:14 -0000      1.34
+++ libamf/amf.cpp      2 May 2007 07:34:34 -0000       1.35
@@ -16,7 +16,7 @@
 // Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA  02110-1301  USA
 //
 
-/* $Id: amf.cpp,v 1.34 2007/04/30 17:24:14 martinwguy Exp $ */
+/* $Id: amf.cpp,v 1.35 2007/05/02 07:34:34 strk Exp $ */
 
 #ifdef HAVE_CONFIG_H
 #include "config.h"
@@ -727,7 +727,7 @@
         memset(buf, 0, length+1);
         memcpy(buf, x, length);
     } else {
-        log_warning("Tried to extract AMF string from non String object!");
+        log_error("Tried to extract AMF string from non String object!");
     }
     
     return buf;
@@ -746,7 +746,7 @@
         memcpy(num, x, AMF_NUMBER_SIZE);
         swapBytes(num, AMF_NUMBER_SIZE);
     } else {
-        log_warning("Tried to extract AMF Number from non Number object!");
+        log_error("Tried to extract AMF Number from non Number object!");
     }
 
     return num;

Index: libbase/log.h
===================================================================
RCS file: /sources/gnash/gnash/libbase/log.h,v
retrieving revision 1.47
retrieving revision 1.48
diff -u -b -r1.47 -r1.48
--- libbase/log.h       16 Apr 2007 10:26:59 -0000      1.47
+++ libbase/log.h       2 May 2007 07:34:34 -0000       1.48
@@ -14,7 +14,7 @@
 // along with this program; if not, write to the Free Software
 // Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA  02110-1301  USA
 
-/* $Id: log.h,v 1.47 2007/04/16 10:26:59 jgilmore Exp $ */
+/* $Id: log.h,v 1.48 2007/05/02 07:34:34 strk Exp $ */
 
 #ifndef GNASH_LOG_H
 #define GNASH_LOG_H
@@ -189,7 +189,11 @@
 DSOEXPORT void log_error(const char* fmt, ...) GNUC_LOG_ATTRS;
 
 // Temporary expedient til the other source files are converted.  --gnu
-#define log_warning    log_unimpl
+// I'm not sure a WARNING logger should really be deprecated, anyway
+// there are no more log_warning callers so far. If anyone feels like using
+// it (ie: the other log levels seem not appropriate) please discuss this on 
the
+// mailing list
+//#define log_warning  log_unimpl
 
 /// Log a message about unimplemented features.
 //

Index: server/as_function.cpp
===================================================================
RCS file: /sources/gnash/gnash/server/as_function.cpp,v
retrieving revision 1.30
retrieving revision 1.31
diff -u -b -r1.30 -r1.31
--- server/as_function.cpp      18 Apr 2007 09:35:42 -0000      1.30
+++ server/as_function.cpp      2 May 2007 07:34:35 -0000       1.31
@@ -145,7 +145,7 @@
        get_member("prototype", &proto);
        if ( proto.to_object() != _properties.get() )
        {
-               log_warning(_("Exported interface of function %p "
+               log_debug(_("Exported interface of function %p "
                                "has been overwritten (from %p to %p)"),
                                this, _properties.get(),
                                (void*)proto.to_object().get());

Index: server/button_character_instance.cpp
===================================================================
RCS file: /sources/gnash/gnash/server/button_character_instance.cpp,v
retrieving revision 1.46
retrieving revision 1.47
diff -u -b -r1.46 -r1.47
--- server/button_character_instance.cpp        29 Apr 2007 14:08:44 -0000      
1.46
+++ server/button_character_instance.cpp        2 May 2007 07:34:35 -0000       
1.47
@@ -322,13 +322,6 @@
 bool
 button_character_instance::on_event(const event_id& id)
 {
-#if 0
-       if (id.m_id != event_id::KEY_PRESS)
-       {
-               log_warning(_("Unsupported event for button instance: %s"), 
id.get_function_name().c_str());
-               return false;
-       }
-#endif
 
        static const event_id s_key[32] =
        {
@@ -638,7 +631,7 @@
        }
        else
        {
-               //log_warning(_("No handler for event: %s"), 
event.get_function_name().c_str());
+               //log_debug(_("No handler for event: %s"), 
event.get_function_name().c_str());
        }
 
 

Index: server/character.cpp
===================================================================
RCS file: /sources/gnash/gnash/server/character.cpp,v
retrieving revision 1.39
retrieving revision 1.40
diff -u -b -r1.39 -r1.40
--- server/character.cpp        26 Apr 2007 10:56:50 -0000      1.39
+++ server/character.cpp        2 May 2007 07:34:35 -0000       1.40
@@ -17,7 +17,7 @@
 // Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA  02110-1301  USA
 // 
 
-/* $Id: character.cpp,v 1.39 2007/04/26 10:56:50 zoulunkai Exp $ */
+/* $Id: character.cpp,v 1.40 2007/05/02 07:34:35 strk Exp $ */
 
 #ifdef HAVE_CONFIG_H
 #include "config.h"
@@ -160,7 +160,7 @@
                {
                        IF_VERBOSE_ASCODING_ERRORS(
                        // AS code trying to access something before the root
-                       log_warning(_("ActionScript code trying to reference"
+                       log_aserror(_("ActionScript code trying to reference"
                                " a nonexistent parent with '..' "
                                " (a nonexistent parent probably only "
                                "occurs in the root MovieClip)."

Index: server/sprite_instance.cpp
===================================================================
RCS file: /sources/gnash/gnash/server/sprite_instance.cpp,v
retrieving revision 1.261
retrieving revision 1.262
diff -u -b -r1.261 -r1.262
--- server/sprite_instance.cpp  2 May 2007 06:55:12 -0000       1.261
+++ server/sprite_instance.cpp  2 May 2007 07:34:35 -0000       1.262
@@ -642,7 +642,7 @@
                        tgtmat.transform(tgtbounds);
 
                        if ( ! warned_1_arg ) {
-                               log_warning("MovieClip.hitTest(%s) TESTING", 
tgt_val.to_debug_string().c_str());
+                               log_debug("MovieClip.hitTest(%s) TESTING", 
tgt_val.to_debug_string().c_str());
                                warned_1_arg=true;
                        }
 
@@ -657,7 +657,7 @@
                        float y = PIXELS_TO_TWIPS(fn.arg(1).to_number(&env));
 
                        if ( ! warned_2_arg ) {
-                               log_warning("MovieClip.hitTest(%g,%g) TESTING", 
x,y);
+                               log_debug("MovieClip.hitTest(%g,%g) TESTING", 
x,y);
                                warned_2_arg=true;
                        }
 

Index: server/asobj/NetStreamGst.cpp
===================================================================
RCS file: /sources/gnash/gnash/server/asobj/NetStreamGst.cpp,v
retrieving revision 1.25
retrieving revision 1.26
diff -u -b -r1.25 -r1.26
--- server/asobj/NetStreamGst.cpp       1 May 2007 20:33:27 -0000       1.25
+++ server/asobj/NetStreamGst.cpp       2 May 2007 07:34:35 -0000       1.26
@@ -17,7 +17,7 @@
 // Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA  02110-1301  USA
 //
 
-/* $Id: NetStreamGst.cpp,v 1.25 2007/05/01 20:33:27 strk Exp $ */
+/* $Id: NetStreamGst.cpp,v 1.26 2007/05/02 07:34:35 strk Exp $ */
 
 #ifdef HAVE_CONFIG_H
 #include "config.h"
@@ -328,7 +328,7 @@
        assert(ns);
        if ( !nc->openConnection(ns->url.c_str(), ns) ) {
                ns->setStatus("NetStream.Play.StreamNotFound");
-               log_warning(_("Gnash could not open movie: %s"), 
ns->url.c_str());
+               log_debug(_("Gnash could not open movie: %s"), ns->url.c_str());
                return;
        }
 
@@ -345,7 +345,7 @@
                ns->m_parser = new FLVParser();
                if (!nc->connectParser(ns->m_parser)) {
                        ns->setStatus("NetStream.Play.StreamNotFound");
-                       log_error(_("Gnash could not open movie: %s"), 
ns->url.c_str());
+                       log_debug(_("Gnash could not open movie: %s"), 
ns->url.c_str());
                        return;
                        
                }

Index: server/swf/tag_loaders.cpp
===================================================================
RCS file: /sources/gnash/gnash/server/swf/tag_loaders.cpp,v
retrieving revision 1.92
retrieving revision 1.93
diff -u -b -r1.92 -r1.93
--- server/swf/tag_loaders.cpp  25 Apr 2007 11:29:12 -0000      1.92
+++ server/swf/tag_loaders.cpp  2 May 2007 07:34:35 -0000       1.93
@@ -17,7 +17,7 @@
 // Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA  02110-1301  USA
 //
 
-/* $Id: tag_loaders.cpp,v 1.92 2007/04/25 11:29:12 martinwguy Exp $ */
+/* $Id: tag_loaders.cpp,v 1.93 2007/05/02 07:34:35 strk Exp $ */
 
 #ifdef HAVE_CONFIG_H
 #include "config.h"
@@ -1545,7 +1545,7 @@
 
     if ( ! flags.use_network )
     {
-       log_warning(_("FileAttributes tag in the SWF requests that "
+       log_unimpl(_("FileAttributes tag in the SWF requests that "
                    "network access is not granted to this movie "
                    "(or application?). Anyway Gnash won't care; "
                    "use white/black listing in your .gnashrc instead"));