Re: [Gnash-commit] gnash ChangeLog libbase/FLVParser.cpp server/as...

[strk]

On Mon, May 07, 2007 at 11:15:44PM +0000, Tomas Groth wrote:

> +             if (_video) _lastVideoFrame = -1;
> +             if (_audio) _lastAudioFrame = -1;

_lastVideoFrame and _lastAudioFrame are *unsigned* values,
assigning negative numbers is asking for troubles. 
What about using 1-based offsets or renaming to _next{Video/Audio}Frame
instead? 

These are the compiler warnings:

libbase/FLVParser.cpp: In constructor 'FLVParser::FLVParser()':
libbase/FLVParser.cpp:36: warning: converting negative value 
'-0x00000000000000001' to 'size_t'
libbase/FLVParser.cpp:36: warning: converting negative value 
'-0x00000000000000001' to 'size_t'
libbase/FLVParser.cpp: In member function 'uint32_t FLVParser::seek(uint32_t)':
libbase/FLVParser.cpp:445: warning: converting negative value 
'-0x00000000000000001' to 'size_t'
libbase/FLVParser.cpp:446: warning: converting negative value 
'-0x00000000000000001' to 'size_t'


--strk;