[Gnash-commit] gnash ChangeLog testsuite/misc-ming.all/Drawing...

[Sandro Santilli]

CVSROOT:        /sources/gnash
Module name:    gnash
Changes by:     Sandro Santilli <strk>  07/05/08 22:13:47

Modified files:
        .              : ChangeLog 
        testsuite/misc-ming.all: DrawingApiTestRunner.cpp 

Log message:
                * testsuite/misc-ming.all/DrawingApiTestRunner.cpp: tolerate
                  a 1-pixel Y drift for the harilined black line, as introduced
                  by latest "pixel hinting" "fix" in AGG (see bug #19775);
                  Also, changed checked point for the diagonal violet line for
                  the same reason. See bug #19828 for more info.

CVSWeb URLs:
http://cvs.savannah.gnu.org/viewcvs/gnash/ChangeLog?cvsroot=gnash&r1=1.3131&r2=1.3132
http://cvs.savannah.gnu.org/viewcvs/gnash/testsuite/misc-ming.all/DrawingApiTestRunner.cpp?cvsroot=gnash&r1=1.14&r2=1.15

Patches:
Index: ChangeLog
===================================================================
RCS file: /sources/gnash/gnash/ChangeLog,v
retrieving revision 1.3131
retrieving revision 1.3132
diff -u -b -r1.3131 -r1.3132
--- ChangeLog   8 May 2007 21:45:46 -0000       1.3131
+++ ChangeLog   8 May 2007 22:13:47 -0000       1.3132
@@ -1,5 +1,10 @@
 2007-05-08 Sandro Santilli <address@hidden>
 
+       * testsuite/misc-ming.all/DrawingApiTestRunner.cpp: tolerate
+         a 1-pixel Y drift for the harilined black line, as introduced
+         by latest "pixel hinting" "fix" in AGG (see bug #19775);
+         Also, changed checked point for the diagonal violet line for
+         the same reason. See bug #19828 for more info.
        * extensions/dejagnu/Makefile.am, extensions/gtk2/Makefile.am,
          extensions/mysql/Makefile.am: remove other direct references
          to convenience libraries.

Index: testsuite/misc-ming.all/DrawingApiTestRunner.cpp
===================================================================
RCS file: 
/sources/gnash/gnash/testsuite/misc-ming.all/DrawingApiTestRunner.cpp,v
retrieving revision 1.14
retrieving revision 1.15
diff -u -b -r1.14 -r1.15
--- testsuite/misc-ming.all/DrawingApiTestRunner.cpp    4 May 2007 09:29:52 
-0000       1.14
+++ testsuite/misc-ming.all/DrawingApiTestRunner.cpp    8 May 2007 22:13:47 
-0000       1.15
@@ -73,6 +73,7 @@
        rgba red(255, 0, 0, 255);
        rgba yellow(255, 255, 0, 255);
        rgba black(0, 0, 0, 255);
+       rgba gray(127, 127, 127, 255);
        rgba violet(255, 0, 255, 255);
        rgba halftrans_violet(255, 128, 255, 255);
 
@@ -116,17 +117,26 @@
        // Over the black "hairlined" line
        tester.movePointerTo(250, 180);
        check(tester.isMouseOverMouseEntity());
-       check_pixel(250, 180, 1, black, 2);
+       // The line used to be rendered at Y=180.
+       // After pixel hinting was touched (see bug #19775)
+       // it moved to Y=179. Since isMouseOverMouseEntity()
+       // would return false for 250,180 we're going to
+       // tolerate the drift of one pixel for the line.
+       // This will accept both 179 and 180 as valid positions
+       // for the line. In the future we might add test for 
+       // exact placement using a more focused testcase.
+       // See bug #19828 for more info about this change.
+       check_pixel(250, 180, 2, gray, 2);
 
        // Over the transparent line (150,100)
        tester.movePointerTo(150, 100);
        check(!tester.isMouseOverMouseEntity()); 
        check_pixel(150, 100, 2, white, 2); 
 
-       // Over the violet line (146,225)
-       tester.movePointerTo(146, 225);
+       // Over the violet line (146,224)
+       tester.movePointerTo(146, 224);
        check(tester.isMouseOverMouseEntity());
-       check_pixel(146, 225, 1, halftrans_violet, 2);
+       check_pixel(146, 224, 1, halftrans_violet, 2);
 
        // Inside the yellow line
        tester.movePointerTo(270, 232);