[Gnash-commit] gnash ChangeLog server/sprite_instance.cpp test...

[Sandro Santilli]

CVSROOT:        /sources/gnash
Module name:    gnash
Changes by:     Sandro Santilli <strk>  07/05/10 10:08:32

Modified files:
        .              : ChangeLog 
        server         : sprite_instance.cpp 
        testsuite/actionscript.all: MovieClip.as 

Log message:
                * testsuite/actionscript.all/MovieClip.as: more and better 
tests for
                  MovieClip.enabled.
                * server/sprite_instance.cpp (attachMovieClipInterface): 
initialize
                  an 'enabled' property in MovieClip.prototype (fixes old and 
new
                  tests for it in MovieClip.as);

CVSWeb URLs:
http://cvs.savannah.gnu.org/viewcvs/gnash/ChangeLog?cvsroot=gnash&r1=1.3150&r2=1.3151
http://cvs.savannah.gnu.org/viewcvs/gnash/server/sprite_instance.cpp?cvsroot=gnash&r1=1.265&r2=1.266
http://cvs.savannah.gnu.org/viewcvs/gnash/testsuite/actionscript.all/MovieClip.as?cvsroot=gnash&r1=1.68&r2=1.69

Patches:
Index: ChangeLog
===================================================================
RCS file: /sources/gnash/gnash/ChangeLog,v
retrieving revision 1.3150
retrieving revision 1.3151
diff -u -b -r1.3150 -r1.3151
--- ChangeLog   10 May 2007 09:49:52 -0000      1.3150
+++ ChangeLog   10 May 2007 10:08:32 -0000      1.3151
@@ -1,5 +1,13 @@
 2007-05-10 Sandro Santilli <address@hidden>
 
+       * testsuite/actionscript.all/MovieClip.as: more and better tests for
+         MovieClip.enabled.
+       * server/sprite_instance.cpp (attachMovieClipInterface): initialize
+         an 'enabled' property in MovieClip.prototype (fixes old and new
+         tests for it in MovieClip.as); 
+
+2007-05-10 Sandro Santilli <address@hidden>
+
        * testsuite/misc-ming.all/displaylist_depths_test2.c: target
          SWF7, use getInstanceAtDepth() to verify Gnash succeeds the
          test, despite the fact it's "soft references" implementation 

Index: server/sprite_instance.cpp
===================================================================
RCS file: /sources/gnash/gnash/server/sprite_instance.cpp,v
retrieving revision 1.265
retrieving revision 1.266
diff -u -b -r1.265 -r1.266
--- server/sprite_instance.cpp  10 May 2007 09:26:56 -0000      1.265
+++ server/sprite_instance.cpp  10 May 2007 10:08:32 -0000      1.266
@@ -1458,6 +1458,8 @@
        o.init_member("globalToLocal", new 
builtin_function(sprite_globalToLocal));
        o.init_member("localToGlobal", new 
builtin_function(sprite_localToGlobal));
        o.init_member("getSWFVersion", new 
builtin_function(sprite_getSWFVersion));
+       o.init_member("enabled", true); // see MovieClip.as testcase
+
        if ( target_version  < 6 ) return;
 
        // SWF6 or higher
@@ -1504,7 +1506,6 @@
        gettersetter = new builtin_function(&character::x_getset, NULL);
        o.init_property("_x", *gettersetter, *gettersetter);
 
-
        gettersetter = new builtin_function(&character::y_getset, NULL);
        o.init_property("_y", *gettersetter, *gettersetter);
 

Index: testsuite/actionscript.all/MovieClip.as
===================================================================
RCS file: /sources/gnash/gnash/testsuite/actionscript.all/MovieClip.as,v
retrieving revision 1.68
retrieving revision 1.69
diff -u -b -r1.68 -r1.69
--- testsuite/actionscript.all/MovieClip.as     10 May 2007 09:26:56 -0000      
1.68
+++ testsuite/actionscript.all/MovieClip.as     10 May 2007 10:08:32 -0000      
1.69
@@ -22,7 +22,7 @@
 // compile this test case with Ming makeswf, and then
 // execute it like this gnash -1 -r 0 -v out.swf
 
-rcsid="$Id: MovieClip.as,v 1.68 2007/05/10 09:26:56 strk Exp $";
+rcsid="$Id: MovieClip.as,v 1.69 2007/05/10 10:08:32 strk Exp $";
 
 #include "check.as"
 
@@ -63,6 +63,29 @@
 check_equals(typeof(mc.getSWFVersion), 'function');
 check_equals(mc.getSWFVersion(), OUTPUT_VERSION);
 
+check_equals(typeof(mc.enabled), 'boolean');
+#if OUTPUT_VERSION >= 6
+check(!mc.hasOwnProperty('enabled'));
+check(mc.__proto__.hasOwnProperty('enabled'));
+#endif
+check_equals(mc.enabled, true);
+mc.enabled = false;
+check_equals(typeof(mc.enabled), 'boolean');
+check_equals(mc.enabled, false);
+mc.enabled = 'a string';
+check_equals(typeof(mc.enabled), 'string');
+check_equals(mc.enabled, 'a string');
+mc.enabled = 56.5;
+check_equals(typeof(mc.enabled), 'number');
+check_equals(mc.enabled, 56.5);
+check(delete mc.enabled);
+check_equals(typeof(mc.enabled), 'boolean');
+check_equals(mc.enabled, true);
+mc.__proto__.enabled = 'a string';
+check_equals(typeof(mc.enabled), 'string'); // yes, we can set to arbitrary 
values
+check_equals(mc.enabled, 'a string'); // yes, we can set to arbitrary values
+mc.__proto__.enabled = true; // better keep as it was initially, who knows 
what it would do...
+
 // This seems unavailable
 // when targetting SWF > 6
 #if OUTPUT_VERSION > 6
@@ -120,8 +143,6 @@
     // maybe we should just NOT use the _root for this ?
     //check(mc.loadVariables != undefined);
 
-    xcheck(mc.enabled);
-
     // maybe this is the start condition...
     check_equals(mc.focusEnabled, undefined);
     check_equals(mc.hitArea, undefined);
@@ -466,6 +487,7 @@
 #if OUTPUT_VERSION > 5
 check_equals(a, "changed");
 #else
+// this check fails with Adobe Flash Player 9
 check_equals(a, undefined);
 #endif
 
@@ -488,6 +510,7 @@
 #if OUTPUT_VERSION > 5
 check_equals(a, "changed");
 #else
+// this check fails with Adobe Flash Player 9
 check_equals(a, undefined);
 #endif