gnash-commit
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Gnash-commit] gnash ChangeLog server/character.h server/dlist...


From: Sandro Santilli
Subject: Re: [Gnash-commit] gnash ChangeLog server/character.h server/dlist...
Date: Sat, 12 May 2007 08:30:09 +0200

On Sat, May 12, 2007 at 02:00:30PM +0800, zou lunkai wrote:
> comments in  sprite_instance::restoreDisplayList(size_t tgtFrame) is 
> cheating:)
> 
> +    // 1. Remove from current DisplayList any timeline instance constructed
> +     //    after target frame and still found at the same depth it had at
> +     //    time of placement.
> 
> you removed more than that!  See
> "http://www.gnashdev.org/wiki/index.php/TimelineControl#Implementation_details_2";
> I guess the comments should be "Find the instances currently in
> DisplayList that need to be removed ", which is more correct, although
> abstract.
> 
> Great and wonderful implementation, I love that.

Yeah, I like it too :)
THer'e a lot of confusing things we can now wipe out, and we should inspect
the effects of a normal loop-back as it might be worth splitting reconstruction
and reset in two dirfferent functions (current resetDisplayList() does 
something different
and I dunno if should).

--strk;




reply via email to

[Prev in Thread] Current Thread [Next in Thread]