[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Gnash-commit] gnash/testsuite/misc-ming.all

From: strk
Subject: Re: [Gnash-commit] gnash/testsuite/misc-ming.all
Date: Mon, 14 May 2007 12:27:22 +0200

On Mon, May 14, 2007 at 09:30:45AM +0000, Zou Lunkai wrote:
> CVSROOT:      /sources/gnash
> Module name:  gnash
> Changes by:   Zou Lunkai <zoulunkai>  07/05/14 09:30:45
> Modified files:
>       testsuite/misc-ming.all: 
> Log message:
>       testcase for duplicateMovieClip, gnash fails on this

I've seen what the bug is.
I think removeMovieClip is also affected, and who knows what else.
Could you add a test checking effect of being in a 'with' block
while calling duplicateMovieClip ?

The point is that if we just fix as_environment::find_target
we'd still not have the 'with' block used.
Rather we might want to use ActionExec::getVariable()
[ thread.getVariable from Action handlers... ].

The latter would correctly use 'with' info.
If we take this patch we'd better drop the as_environemtn::find_target
or we'll never know how many bugs are still open.
Sounds as a big change and not enough testcases to verify ...

Of course we can just fix duplicateMovieClip and postpone the rest.


reply via email to

[Prev in Thread] Current Thread [Next in Thread]