gnash-commit
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Gnash-commit] gnash ChangeLog backend/sound_handler_gst.cpp b...


From: strk
Subject: Re: [Gnash-commit] gnash ChangeLog backend/sound_handler_gst.cpp b...
Date: Tue, 15 May 2007 12:41:49 +0200

On Tue, May 15, 2007 at 12:12:26PM +0200, Tomas Groth wrote:
> 
> --- Martin Guy <address@hidden> skrev:
> 
> > > +               for (int i = 0; i < data_bytes; i++)
> > > +               {
> > > +                   data[i] = in->read_u8();
> > > +               }
> > 
> > We now have
> >     in->read((char *)data, databytes);
> > 
> > If u can put this in that'd be great; my tag_loaders is dirty with the
> > other half of the uncompressed sound fixes.
> > Or I will... put on my TODO
> > 
> Ohh, nice. i'll add it.

Please check return code to verify it was able to read as much 
data as you requested it, and either assert, throw a ParseException,
log the malformed SWF ... whatever, just don't miss checking it :)

--strk;




reply via email to

[Prev in Thread] Current Thread [Next in Thread]