Re: [Gnash-commit] gnash libbase/log.h ChangeLog

[Rob Savoye]

strk wrote:

>> Log message:
>>          * libbase/log.h: Add empty braces around a while(0) to shut up GCC 
>> 4.3.

  This was on purpose, to shut gcc 4.3 up.

>>  // Temporary expedient til the other source files are converted.  --gnu
>> -// I'm not sure a WARNING logger should really be deprecated, anyway
>> -// there are no more log_warning callers so far. If anyone feels like using
>> -// it (ie: the other log levels seem not appropriate) please discuss this 
>> on the
>> -// mailing list
>> -//#define log_warning       log_unimpl
>> +#define log_warning log_unimpl
> 
> Was the above committed accidentally or intentionally ?
> (since no mention in the commit log...)

  Oops, this was a mistake, and I'm not even sure where it came from, as
it's not even my code. If can be deleted.

        - rob -