[Gnash-commit] gnash ChangeLog server/dlist.cpp

[Sandro Santilli]

CVSROOT:        /sources/gnash
Module name:    gnash
Changes by:     Sandro Santilli <strk>  07/05/24 11:57:55

Modified files:
        .              : ChangeLog 
        server         : dlist.cpp 

Log message:
                * server/dlist.cpp (replace_character): always call ::construct
                  on the new character.

CVSWeb URLs:
http://cvs.savannah.gnu.org/viewcvs/gnash/ChangeLog?cvsroot=gnash&r1=1.3336&r2=1.3337
http://cvs.savannah.gnu.org/viewcvs/gnash/server/dlist.cpp?cvsroot=gnash&r1=1.67&r2=1.68

Patches:
Index: ChangeLog
===================================================================
RCS file: /sources/gnash/gnash/ChangeLog,v
retrieving revision 1.3336
retrieving revision 1.3337
diff -u -b -r1.3336 -r1.3337
--- ChangeLog   24 May 2007 11:46:28 -0000      1.3336
+++ ChangeLog   24 May 2007 11:57:54 -0000      1.3337
@@ -1,5 +1,7 @@
 2007-05-24 Sandro Santilli <address@hidden>
 
+       * server/dlist.cpp (replace_character): always call ::construct
+         on the new character.
        * backend/sound_handler_sdl.h: fix const-correctness
          of active_sound (btw, do we really need two different
          definitions of that class for SDL and GST ?).

Index: server/dlist.cpp
===================================================================
RCS file: /sources/gnash/gnash/server/dlist.cpp,v
retrieving revision 1.67
retrieving revision 1.68
diff -u -b -r1.67 -r1.68
--- server/dlist.cpp    23 May 2007 16:30:10 -0000      1.67
+++ server/dlist.cpp    24 May 2007 11:57:55 -0000      1.68
@@ -287,8 +287,6 @@
                // add the new char
                _characters.insert(it, di);
 
-               // Give life to this instance
-               ch->construct();
        }
        else
        {
@@ -314,12 +312,18 @@
                *it = di;
                
                // extend invalidated bounds
+               // WARNING: when a new Button character is added,
+               //          the invalidated bounds computation will likely
+               //          be bogus, as the actual character shown is not 
instantiated
+               //          until ::construct for buttons (I'd say this is a 
bug in button_character_instance)
+               //          UdoG, following ? 
+               //
                ch->extend_invalidated_bounds(old_ranges);                      
        
 
-               // TODO: check: Shouldn't we construct the new object here too ?
-               //ch->construct();
        }
 
+       // Give life to this instance
+       ch->construct();
 }