[Gnash-commit] gnash ChangeLog devtools/testsuite/copyright_no...

[Ann Barcomb]

CVSROOT:        /sources/gnash
Module name:    gnash
Changes by:     Ann Barcomb <ann>       07/05/28 15:07:25

Modified files:
        .              : ChangeLog 
        devtools/testsuite: copyright_notices.t 

Log message:
        It's silly to close the file in two places, it can just be closed after 
it's
        been read in.

CVSWeb URLs:
http://cvs.savannah.gnu.org/viewcvs/gnash/ChangeLog?cvsroot=gnash&r1=1.3380&r2=1.3381
http://cvs.savannah.gnu.org/viewcvs/gnash/devtools/testsuite/copyright_notices.t?cvsroot=gnash&r1=1.2&r2=1.3

Patches:
Index: ChangeLog
===================================================================
RCS file: /sources/gnash/gnash/ChangeLog,v
retrieving revision 1.3380
retrieving revision 1.3381
diff -u -b -r1.3380 -r1.3381
--- ChangeLog   28 May 2007 14:59:24 -0000      1.3380
+++ ChangeLog   28 May 2007 15:07:25 -0000      1.3381
@@ -1,5 +1,6 @@
 2007-05-27 Ann Barcomb <address@hidden>
 
+       * devtools/testsuite/copyright_notices.t: Minor code improvement
        * many files: Add current year to all copyright notices which were
          lacking it.
 

Index: devtools/testsuite/copyright_notices.t
===================================================================
RCS file: /sources/gnash/gnash/devtools/testsuite/copyright_notices.t,v
retrieving revision 1.2
retrieving revision 1.3
diff -u -b -r1.2 -r1.3
--- devtools/testsuite/copyright_notices.t      28 May 2007 11:33:31 -0000      
1.2
+++ devtools/testsuite/copyright_notices.t      28 May 2007 15:07:25 -0000      
1.3
@@ -27,13 +27,13 @@
     ## Read in the entire file, as some of the cleaning spans lines
     local $/ = undef;
     my $entire_file = <$fh>;
+    close $fh;
 
     my @reason;
 
     ## If there is no copyright notice, skip other checks
     if ($entire_file !~ m|This program is free software; you can|) {
         push @failures => "$path:\n\t* Copyright notice is missing.\n";
-        close $fh;
         next FILE;
     }
 
@@ -60,13 +60,14 @@
     }
 
     push @failures => "$path:\n\t". (join "\n\t", @reason) ."\n" if (@reason);
-    close $fh;
 }
 
 ok( !scalar(@failures), "Incorrect GNU copyright notice" )
     or diag("Incorrect GNU copyright notice found in ".
     scalar @failures." files:address@hidden");
 
+=pod
+
 =head1 NAME
 
 devtools/testsuite/copyright_notices.t - look for incorrect copyright notices