[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Gnash-commit] gnash server/asobj/NetStreamFfmpeg.cpp ChangeLog

From: Martin Guy
Subject: Re: [Gnash-commit] gnash server/asobj/NetStreamFfmpeg.cpp ChangeLog
Date: Wed, 30 May 2007 12:41:47 +0100

2007/5/30, Martin Guy <address@hidden>:
* server/asobj/NetStreamFfmpeg.cpp: Two casts to quiet compiler warnings

There is another warning which may be a bug:

server/asobj/NetStreamFfmpeg.cpp:1218: warning: passing 'double' for
argument 1 to 'bool FLVParser::isTimeLoaded(uint32_t)'

       if (m_go && m_pause && m_start_onbuffer && m_parser.get() &&

since isTimeLoaded expects a uint32_t but m_current_timestamp is a double
(m_buffer_time is a uint32_t too).

Unfortunately I can't easily see whether this is correct or not since
none of the "time" variable declarations say, as they should, what
units the times are measured in (seconds? milliseconds? SWF frames?
ticks of some kind?) and when they are measured from (from start of
flash movie in realtime seconds? from start of video clip in video

m_current_timestamp seems to be in seconds to a 1/1000 second accuracy;
the others...?

Could someone who knows this code better check this statement is right
(and maybe add the missing comments here and there?)



reply via email to

[Prev in Thread] Current Thread [Next in Thread]