|
From: | Martin Guy |
Subject: | Re: [Gnash-commit] gnash ChangeLog libbase/embedVideoDecoderFfmpeg... |
Date: | Thu, 31 May 2007 20:17:43 +0100 |
2007/5/31, Bastiaan Jacques <address@hidden>:
On Thu, 31 May 2007, Martin Guy wrote: > Bastiaan, shall I get diffs from your modifications and see if I can > munge the two versions into switching on an ifdef (or have you done it > already?) Yes please. Also, I'm very confused about which ffmpeg versions do and do not contain swscale... if you could untangle that mess I would be very grateful. I guess it would be fairly trivial to #ifdef img_convert stuff once you figure that out.
Ok, I've had a go and cant figure out what's supposed to be happening. Of course it doesn't help that none of the functions here have a comment saying what they do. So guess... Unfortunately right after your commit come some rearranging and code-merging commits that move your changes around and generalise the use of the new code, as well as piling a load of extra modifications on top. Does the current sws_scale stuff work as it should with ffmpeg-svn-head? Sadly this blocks building on just about everything except ffmpeg-svn systems. I'm signing off for today; if you want to look at this you may have an easier of implementing the replacement code than me, who am largely having to guess. M
[Prev in Thread] | Current Thread | [Next in Thread] |