[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Gnash-commit] gnash ChangeLog testsuite/actionscript.all/enum...

From: strk
Subject: Re: [Gnash-commit] gnash ChangeLog testsuite/actionscript.all/enum...
Date: Fri, 22 Jun 2007 06:46:57 +0200

On Fri, Jun 22, 2007 at 09:24:25AM +0800, zou lunkai wrote:
> On 6/21/07, strk <address@hidden> wrote:
> >On Thu, Jun 21, 2007 at 02:03:47AM +0000, Zou Lunkai wrote:
> >
> >> +// Test what we got in the above step. Tests show that characters were 
> >also got enumerated!
> >> +// Note: don't use clip names for testing here, the order in 
> >enumerating is not defined.
> >> +// However, the tests bellow are dependent on enumerating order!
> >> +// Since recorder[0] and recorder[1] and recorder[2] might not be 
> >movieclips.
> >> +// TODO: find a proper way to test this.
> >
> >use recorder[name] = 1;
> >and check_equals(typeof(recorder['name']), 'movieclip');
> >
> Thanks. Done. Tests should be safe now.
> Any one like to fix it:)?

The bug is in characters not being proper properties, but rather
handler from overridden set_member/get_member methods.
One solution could be making enumerateObject a virtual function itself
so that whoever overrides set_member/get_member can also override
the latter. 
Another solution would be turning childs into proper read-only properties.
Have you tried using hasOwnProperty('childname') ?


 ()   ASCII Ribbon Campaign
 /\   Keep it simple! 

reply via email to

[Prev in Thread] Current Thread [Next in Thread]