[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Gnash-commit] gnash ChangeLog testsuite/misc-ming.all/key_eve...

From: Sandro Santilli
Subject: Re: [Gnash-commit] gnash ChangeLog testsuite/misc-ming.all/key_eve...
Date: Wed, 11 Jul 2007 15:23:02 +0200

On Wed, Jul 11, 2007 at 04:39:59PM +0800, zou lunkai wrote:
> +  // Gnash fails because it forget to do the case conversion.
> +  // A big old bug!
> Backgroud: For swf < 7,  variable names are case insensitive, and
> Gnash stores all variables in lower case and does a case conversion
> when searching a variable.
> Not difficult to fix this bug, adding a case conversion in
> sprite_instance::get_member () probably works. I am just confused at
> which level should we do this case conversion. A quich search shows
> that Gnash does this(boost::to_lower) in many places than I expect.
> But it still forgets to do this conversion sometimes, eg. the above
> example and when parsing a target path. Any comments about this?

I tried to perform all convertions in ActionExec, which is as close as possible
to the SWF interpreter (AsHadners).

The find_target seems to not happen there, but directly in as_environment
instead. Also, I think characters, in general, are not lowercased


reply via email to

[Prev in Thread] Current Thread [Next in Thread]