[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Gnash-commit] gnash ChangeLog server/edit_text_character.cpp ...

From: strk
Subject: Re: [Gnash-commit] gnash ChangeLog server/edit_text_character.cpp ...
Date: Sun, 22 Jul 2007 14:45:03 +0200

On Fri, Jul 20, 2007 at 06:47:23PM +0200, Udo Giacomozzi wrote:

> UG> +    // set alpha to default values to make the text field opaque
> UG> +    cf.m_[3][0] = 1.0f;
> UG> +    cf.m_[3][1] = 0.0f;
> Yes, I know, we should add a setAlpha() or similar function to the
> cxform class...

Actually, it seems that to obtain full "dumb" compatibility would
be to return a default-constructed cxform here. See input-field.swf.
Your vesrion only handles _alpha, while the test shows also colors
do not have effect.

Now for the redesign part :)
If we avoid calling get_world_cxform in *two* places like we're doing 
now (once for border/background and one from inside display_glyph_records)
we could then move the "dumb compatibility" check inside ::display
and avoid the get_world_cxform override completely.


reply via email to

[Prev in Thread] Current Thread [Next in Thread]