[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re[2]: [Gnash-commit] gnash ChangeLog server/dlist.cpp
From: |
Udo Giacomozzi |
Subject: |
Re[2]: [Gnash-commit] gnash ChangeLog server/dlist.cpp |
Date: |
Tue, 24 Jul 2007 18:28:10 +0200 |
Hello strk,
Tuesday, July 24, 2007, 4:31:46 PM, you wrote:
s> bool isMask() const { return m_clip_depth!=noClipDepthValue; }
noClipDepthValue still exists!? ;)
s> Could it be we "forget" to set the clip depth to noClipDepthValue ?
It's initialized in the constructor of "character".
s> We want to log_swferror on actually malformed SWF, or fix other
s> bugs if the SWF is sane.
s> "hushing" the warning like this doesn't seem safe to me.
In first place this patch is used to make Gnash *stable*. A single
character can never be a double mask.
It's not certain if this is a Gnash bug (ie. we don't handle masks
correctly) or if the SWF is malformed. I get headache whenever I
try to analyze the masks code..
Udo