[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Gnash-commit] gnash ChangeLog server/stream.h server/stream.cpp

From: strk
Subject: Re: [Gnash-commit] gnash ChangeLog server/stream.h server/stream.cpp
Date: Fri, 24 Aug 2007 12:36:54 +0200

On Fri, Aug 24, 2007 at 07:33:38PM +0900, Chad Musick wrote:
> I'm not sure if align() should be called -- I mimicked the read_fixed()
> function in this.

It actually seems that m_unused_bits = 0 is enough to properly align
stuff, so we should likely always call align() and have align() only
set m_unused_bits = 0 (with setting m_current_byte = 0 just being
a waste of time).

Yes, seems a dangerous change, but I'm confident our internal and external
testcases would catch any problem with it.


reply via email to

[Prev in Thread] Current Thread [Next in Thread]