[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Gnash-commit] gnash ChangeLog server/StreamProvider.cpp serve...

From: strk
Subject: Re: [Gnash-commit] gnash ChangeLog server/StreamProvider.cpp serve...
Date: Tue, 30 Oct 2007 08:50:18 +0100

On Mon, Oct 29, 2007 at 09:07:35PM +0000, Chad Musick wrote:

Some logging rationalization:

>       log_msg(_("ActionCastOp TESTING"));

These kind of messages are better printed using log_debug.

> +     if (!obj)
> +     {
> +             log_msg(_("In ImplementsOp, not an object.\n"));
> +             return;

These could be AS coding errors, or malformed SWF error.
Choose one, and wrap as in:
  IF_VERBOSE_ASCODING_ERRORS( log_aserror(...) )
  IF_VERBOSE_MALFORMED_SWF( log_swferror(...) )

The wrapping allows easy compile-time removal of the messages.

> +             log_msg(_("In ImplementsOp, object had no prototype.\n"));

All of log_xxx functions will append a newline themselves, no need for the 
final \n

> +     fprintf(stderr, "Extending.\n");

log_debug, most likely


reply via email to

[Prev in Thread] Current Thread [Next in Thread]