[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Gnash-commit] gnash ChangeLog server/vm/ASHandlers.cpp
From: |
zou lunkai |
Subject: |
Re: [Gnash-commit] gnash ChangeLog server/vm/ASHandlers.cpp |
Date: |
Wed, 21 Nov 2007 09:40:08 +0800 |
> I'm not sure why we're not using the "versioned" one always.
> We should see what happens moving the only additional checks
> from to_string_versioned to to_string and make the former
> just an alias.
I'v no idea why there is a to_string_versioned(), either.
Conceptually, to_string() should take care of swf version itself.
The only reason I used to_string_versioned() is fixing the bug with
minimal changes. swf4 opcodes are not well tested in our testsuite
and I'v already found problems with quite a few opcodes. I plan to
finish the tests first to see if there is a clear picture.
--zou
On Nov 21, 2007 3:42 AM, strk <address@hidden> wrote:
> On Tue, Nov 20, 2007 at 05:53:59AM +0000, Zou Lunkai wrote:
> > CVSROOT: /sources/gnash
> > Module name: gnash
> > Changes by: Zou Lunkai <zoulunkai> 07/11/20 05:53:59
> >
> > Modified files:
> > . : ChangeLog
> > server/vm : ASHandlers.cpp
> >
> > Log message:
> > * server/vm/AsHandlers.cpp: using to_string_versioned() for opcode
> > ActionStringEq,
> > fix bug21567.
>
> I'm not sure why we're not using the "versioned" one always.
> We should see what happens moving the only additional checks
> from to_string_versioned to to_string and make the former
> just an alias.
>
> --strk;
>