[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Gnash-commit] gnash ChangeLog server/as_environment.h server/...

From: strk
Subject: Re: [Gnash-commit] gnash ChangeLog server/as_environment.h server/...
Date: Thu, 22 Nov 2007 12:30:01 +0100

On Thu, Nov 22, 2007 at 11:09:55AM +0000, Chad Musick wrote:
> CVSROOT:      /sources/gnash

>       boost::intrusive_ptr<as_object> obj = this;
>       while (obj && visited.insert(obj.get()).second)
>       {
> +             ++i;
> +             if ((i > 255 && swfVersion == 5) || i > 257)
> +                     throw ActionLimitException("Lookup depth exceeded.");

I suggest we fetch the limits using a method. Later the method
would ask the VM, which would ask the RcInitFile.

We do something like that in ActionExec (getScriptTimeout())
and also something like the hard-coded one (maxBranchCount).

We should unify so all limits checker ask the VM so will
be easier to modify at runtime or trough .gnashrc or by
loading SWF tags (there's a tag containing that info)


reply via email to

[Prev in Thread] Current Thread [Next in Thread]