[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Gnash-commit] gnash ChangeLog server/parser/action_buffer.h t...
From: |
Sandro Santilli |
Subject: |
[Gnash-commit] gnash ChangeLog server/parser/action_buffer.h t... |
Date: |
Mon, 26 Nov 2007 13:14:02 +0000 |
CVSROOT: /sources/gnash
Module name: gnash
Changes by: Sandro Santilli <strk> 07/11/26 13:14:01
Modified files:
. : ChangeLog
server/parser : action_buffer.h
testsuite/misc-swfmill.all: dict_override.xml
Log message:
cleanups and comments update
CVSWeb URLs:
http://cvs.savannah.gnu.org/viewcvs/gnash/ChangeLog?cvsroot=gnash&r1=1.4966&r2=1.4967
http://cvs.savannah.gnu.org/viewcvs/gnash/server/parser/action_buffer.h?cvsroot=gnash&r1=1.19&r2=1.20
http://cvs.savannah.gnu.org/viewcvs/gnash/testsuite/misc-swfmill.all/dict_override.xml?cvsroot=gnash&r1=1.1&r2=1.2
Patches:
Index: ChangeLog
===================================================================
RCS file: /sources/gnash/gnash/ChangeLog,v
retrieving revision 1.4966
retrieving revision 1.4967
diff -u -b -r1.4966 -r1.4967
--- ChangeLog 26 Nov 2007 12:56:34 -0000 1.4966
+++ ChangeLog 26 Nov 2007 13:14:01 -0000 1.4967
@@ -1,5 +1,7 @@
2007-11-26 Sandro Santilli <address@hidden>
+ * server/parser/action_buffer.h: cleanup and comments fix
+ * testsuite/misc-swfmill.all/dict_override.xml: comments fix.
* server/parser/movie_def_impl.{cpp,h}: consistent locking for
_frames_loaded (so helgrind is happy).
* gui/: Makefile.am, gnash.cpp: add CXXFLAGS in --version output.
Index: server/parser/action_buffer.h
===================================================================
RCS file: /sources/gnash/gnash/server/parser/action_buffer.h,v
retrieving revision 1.19
retrieving revision 1.20
diff -u -b -r1.19 -r1.20
--- server/parser/action_buffer.h 30 Oct 2007 18:55:43 -0000 1.19
+++ server/parser/action_buffer.h 26 Nov 2007 13:14:01 -0000 1.20
@@ -65,35 +65,6 @@
/// Read action bytes from input stream up to end of tag
void readFullTag(stream* in);
-#if 0
- /// \brief
- /// Interpret the actions in this action buffer, and evaluate
- /// them in the given environment.
- //
- /// Execute our whole buffer,
- /// without any arguments passed in.
- ///
- /// FIXME: obsolete this, use ActionExec instead.
- ///
- void execute(as_environment* env) const;
-
- /// Interpret the specified subset of the actions in our buffer.
- //
- /// Caller is responsible for cleaning up our local
- /// stack frame (it may have passed its arguments in via the
- /// local stack frame).
- ///
- /// FIXME: obsolete this, use ActionExec instead.
- ///
- void execute(
- as_environment* env,
- size_t start_pc,
- size_t exec_bytes,
- as_value* retval, // we should probably drop this parameter
- const std::vector<with_stack_entry>& initial_with_stack,
- bool is_function2) const;
-#endif
-
bool is_null() const
{
return m_buffer.size() < 1 || m_buffer[0] == 0;
@@ -232,14 +203,12 @@
return m_dictionary[n];
}
- /// \brief
/// Interpret the SWF::ACTION_CONSTANTPOOL opcode.
//
/// Don't read stop_pc or later.
///
- /// A dictionary is some static strings embedded in the
- /// action buffer; there should only be one dictionary per
- /// action buffer.
+ /// A dictionary is a table of indexed strings to be
+ /// used in action blocks to reduce their size.
///
/// NOTE: Normally the dictionary is declared as the first
/// action in an action buffer, but I've seen what looks like
@@ -253,9 +222,8 @@
/// ... "protected" code here, including the real decl_dict
opcode ...
/// <end of the dummy decl_dict [0] opcode>
///
- /// So we just interpret the first decl_dict we come to, and
- /// cache the results. If we ever hit a different decl_dict in
- /// the same action_buffer, then we log an error and ignore it.
+ /// Note also that the dictionary may be overridden multiple times.
+ /// See testsuite/misc-swfmill.all/dict_override.xml
///
void process_decl_dict(size_t start_pc, size_t stop_pc) const;
Index: testsuite/misc-swfmill.all/dict_override.xml
===================================================================
RCS file: /sources/gnash/gnash/testsuite/misc-swfmill.all/dict_override.xml,v
retrieving revision 1.1
retrieving revision 1.2
diff -u -b -r1.1 -r1.2
--- testsuite/misc-swfmill.all/dict_override.xml 10 Oct 2007 07:01:01
-0000 1.1
+++ testsuite/misc-swfmill.all/dict_override.xml 26 Nov 2007 13:14:01
-0000 1.2
@@ -36,7 +36,7 @@
</items>
</PushData>
- // Set 'a' to 'A_value'
+ // Set 'a' to 'A'
<PushData>
<items>
<StackString value="a"/>
@@ -45,7 +45,7 @@
</PushData>
<SetVariable/>
- // Set 'b' to 'A_value'
+ // Set 'b' to 'B'
<PushData>
<items>
<StackString value="b"/>
[Prev in Thread] |
Current Thread |
[Next in Thread] |
- [Gnash-commit] gnash ChangeLog server/parser/action_buffer.h t...,
Sandro Santilli <=