[Gnash-commit] gnash ChangeLog testsuite/actionscript.all/with.as

[Sandro Santilli]

CVSROOT:        /sources/gnash
Module name:    gnash
Changes by:     Sandro Santilli <strk>  08/02/13 15:42:50

Modified files:
        .              : ChangeLog 
        testsuite/actionscript.all: with.as 

Log message:
        use ASM for setTarget in with() blocks, or Ming 0.4.0.beta6 would 
consider
        it a function call (as done by the official ide, so "correctly").

CVSWeb URLs:
http://cvs.savannah.gnu.org/viewcvs/gnash/ChangeLog?cvsroot=gnash&r1=1.5640&r2=1.5641
http://cvs.savannah.gnu.org/viewcvs/gnash/testsuite/actionscript.all/with.as?cvsroot=gnash&r1=1.38&r2=1.39

Patches:
Index: ChangeLog
===================================================================
RCS file: /sources/gnash/gnash/ChangeLog,v
retrieving revision 1.5640
retrieving revision 1.5641
diff -u -b -r1.5640 -r1.5641
--- ChangeLog   13 Feb 2008 15:17:59 -0000      1.5640
+++ ChangeLog   13 Feb 2008 15:42:50 -0000      1.5641
@@ -1,5 +1,8 @@
 2008-02-13 Sandro Santilli <address@hidden>
 
+       * testsuite/actionscript.all/with.as: use ASM for setTarget in
+         with() blocks, or Ming 0.4.0.beta6 would consider it a function
+         call (as done by the official ide, so "correctly").
        * testsuite/actionscript.all/targetPath.as: AS targetPath doesn't
          change in Ming 0.4.0.beta6, just the ASM label.
 

Index: testsuite/actionscript.all/with.as
===================================================================
RCS file: /sources/gnash/gnash/testsuite/actionscript.all/with.as,v
retrieving revision 1.38
retrieving revision 1.39
diff -u -b -r1.38 -r1.39
--- testsuite/actionscript.all/with.as  14 Nov 2007 22:16:05 -0000      1.38
+++ testsuite/actionscript.all/with.as  13 Feb 2008 15:42:50 -0000      1.39
@@ -21,7 +21,7 @@
 // compile this test case with Ming makeswf, and then
 // execute it like this gnash -1 -r 0 -v out.swf
 
-rcsid="$Id: with.as,v 1.38 2007/11/14 22:16:05 strk Exp $";
+rcsid="$Id: with.as,v 1.39 2008/02/13 15:42:50 strk Exp $";
 
 #include "check.as"
 
@@ -383,13 +383,19 @@
 
 with (o2)
 {
-       setTarget('o:t'); 
+       // NOTE: AS setTarget() used SETTARGET opcode while
+       // ASM settargetexpr uses the setTArgetExpression one.
+       // Problem is that Ming 0.4.0.beta6 correctly compiles
+       // a setTarget() call inside a 'with' block as a function
+       // call rather then as the SETTARGET opcode, so we
+       // *need* to use ASM here, but 'settarget' is not available yet.
+       asm { push 'o:t' settargetexpr }; //setTarget("o:t");
        check_equals(_target, "/clip1");
-       setTarget("");
+       asm { push '' settargetexpr }; //setTarget("");
 }
 
 // 
-// TODO: add tests for setTargetExpression 
+// TODO: add tests for setTarget
 //
 
 #endif  //OUTPUT_VERSION > 5