Re: [Gnash-commit] /srv/bzr/gnash/rtmp r9579: Make sure a pointer for private data isn't 0 before deleting it,

[Bastiaan Jacques]

On Wed, 13 Aug 2008, address@hidden wrote:

> ------------------------------------------------------------
> revno: 9579
> committer: address@hidden
> branch nick: rtmp
> timestamp: Wed 2008-08-13 13:21:46 -0600
> message:
>  Make sure a pointer for private data isn't 0 before deleting it

That's not necessary, because delete (and delete []) check for 0 before
freeing the memory.

Bastiaan

=== modified file 'libamf/element.cpp'
--- a/libamf/element.cpp        2008-08-08 04:38:50 +0000
+++ b/libamf/element.cpp        2008-08-13 19:21:46 +0000
@@ -74,12 +74,15 @@
 Element::~Element()
 {
 //    GNASH_REPORT_FUNCTION;
-       delete _buffer;
-
     for (size_t i=0; i< _properties.size(); i++) {
        delete _properties[i];
     }
+    if (_buffer) {
+       delete _buffer;
+    }
+    if (_name) {
        delete[] _name;
+    }
 }
 
 

_______________________________________________
Gnash-commit mailing list
address@hidden
http://lists.gnu.org/mailman/listinfo/gnash-commit