[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Gnash-commit] /srv/bzr/gnash/trunk r11659: Adapted the OS4 Gui to t

From: Benjamin Wolsey
Subject: Re: [Gnash-commit] /srv/bzr/gnash/trunk r11659: Adapted the OS4 Gui to the recent changes.
Date: Sat, 28 Nov 2009 12:47:03 +0100

>  void 
> -AOS4AggGlue::saveOrigiginalDimension(int width, int height)
> +AOS4AggGlue::saveOrigiginalDimension(int width, int height, int xPosition, 
> int yPosition)

Not that it's anything to do with me, but shouldn't that be

> +    const int32_t gain = clamp(fn.arg(0).to_int(), (boost::int32_t)0, 
> (boost::int32_t)100);

Please use an explicit template argument instead of ugly C-style casts
in these cases: clamp<boost::int32_t>(...) will compile without explicit

>    const int timeout = std::max(fn.arg(1).to_int(), (boost::int32_t)0);

Same here - std::max<boost::int32_t>(...).


Free Flash, use Gnash

Benjamin Wolsey, Software Developer -

Attachment: signature.asc
Description: Dies ist ein digital signierter Nachrichtenteil

reply via email to

[Prev in Thread] Current Thread [Next in Thread]