Re: [Gnash-commit] /srv/bzr/gnash/trunk r12085: Fixed comparsion between signed and unsigned integers

[Bastiaan Jacques]

Now this code fails to compile with:

gtk.cpp: In member function ‘bool gnash::GtkGui::checkX11Extension(const 
std::string&)’:
gtk.cpp:2275: error: invalid conversion from ‘unsigned int*’ to ‘int*’
gtk.cpp:2275: error:   initializing argument 2 of ‘char** 
XListExtensions(Display*, int*)’

So clearly this was the wrong way to fix the warning. Instead of
changing the type of the parameter to XListExtensions(), the way that
*we* compare the signed integer should change.

Bastiaan


On Sat, 20 Mar 2010, Markus Gothe wrote:

> ------------------------------------------------------------
> revno: 12085
> committer: Markus Gothe <address@hidden>
> branch nick: trunk
> timestamp: Sat 2010-03-20 04:06:08 +0100
> message:
>  Fixed comparsion between signed and unsigned integers
> modified:
>  gui/gtk.cpp