[Gnash-commit] [SCM] Gnash branch, master, updated. release_0_8_9_start-514-gc0e0bca

[Benjamin Wolsey]

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "Gnash".

The branch, master has been updated
       via  c0e0bca0158366f4834b35a4b666f9bf93eafaed (commit)
       via  516ba913837c9a74816e23f9a4868cc27fcbb4c8 (commit)
       via  92e671ec6d088cdbf78ed0bb62ded66c319c0e9a (commit)
       via  c2cb4a6db92ebb459f5475f935a685e21b982fb4 (commit)
       via  c97c959440134fb07dcc2ce884aee487ce417ba9 (commit)
       via  59b62a00a6a2515ae970c4d996aa29108b40fdd8 (commit)
       via  71d53053a878796a1610eeb7d2024e7a0e3e0044 (commit)
       via  cb7cfaf5c404744838a26e43f9fd9692310199c6 (commit)
       via  7645643082a893711cfdd6736913f86bd4409da3 (commit)
      from  6dca10c521084891a58b2ff1da44df65990f0b3a (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
http://git.savannah.gnu.org/cgit//commit/?id=c0e0bca0158366f4834b35a4b666f9bf93eafaed


commit c0e0bca0158366f4834b35a4b666f9bf93eafaed
Author: Benjamin Wolsey <address@hidden>
Date:   Mon Apr 4 10:08:56 2011 +0200

    Initialize members in ctor.

diff --git a/libcore/parser/SWFMovieDefinition.cpp 
b/libcore/parser/SWFMovieDefinition.cpp
index 6845ca9..3c49517 100644
--- a/libcore/parser/SWFMovieDefinition.cpp
+++ b/libcore/parser/SWFMovieDefinition.cpp
@@ -155,9 +155,11 @@ SWFMovieDefinition::SWFMovieDefinition(const RunResources& 
runResources)
     m_version(0),
     _frames_loaded(0u),
     _waiting_for_frame(0),
+    _bytes_loaded(0),
     m_loading_sound_stream(-1),
     m_file_length(0),
     m_jpeg_in(0),
+    _swf_end_pos(0),
     _loader(*this),
     _loadingCanceled(false),
     _runResources(runResources),

http://git.savannah.gnu.org/cgit//commit/?id=516ba913837c9a74816e23f9a4868cc27fcbb4c8


commit 516ba913837c9a74816e23f9a4868cc27fcbb4c8
Author: Benjamin Wolsey <address@hidden>
Date:   Mon Apr 4 10:08:32 2011 +0200

    Fix operator typo in assert.

diff --git a/libcore/swf/ScriptLimitsTag.h b/libcore/swf/ScriptLimitsTag.h
index 353742c..264cbcb 100644
--- a/libcore/swf/ScriptLimitsTag.h
+++ b/libcore/swf/ScriptLimitsTag.h
@@ -50,7 +50,7 @@ public:
     static void loader(SWFStream& in, TagType tag, movie_definition& m,
             const RunResources& /*r*/)
     {
-        assert(tag = SWF::SCRIPTLIMITS);
+        assert(tag == SWF::SCRIPTLIMITS);
         boost::intrusive_ptr<ControlTag> s(new ScriptLimitsTag(in));
         m.addControlTag(s);
     }

http://git.savannah.gnu.org/cgit//commit/?id=92e671ec6d088cdbf78ed0bb62ded66c319c0e9a


commit 92e671ec6d088cdbf78ed0bb62ded66c319c0e9a
Author: Benjamin Wolsey <address@hidden>
Date:   Mon Apr 4 10:08:14 2011 +0200

    Initialize members in ctor.

diff --git a/libcore/LoadVariablesThread.cpp b/libcore/LoadVariablesThread.cpp
index fe81a64..27c0428 100644
--- a/libcore/LoadVariablesThread.cpp
+++ b/libcore/LoadVariablesThread.cpp
@@ -101,7 +101,6 @@ LoadVariablesThread::completeLoad()
                }
 
                _bytesLoaded += bytesRead;
-               //dispatchDataEvent();
 
                // eof, get out !
                if ( _stream->eof() ) break;
@@ -144,6 +143,8 @@ LoadVariablesThread::completeLoad()
 LoadVariablesThread::LoadVariablesThread(const StreamProvider& sp,
         const URL& url, const std::string& postdata)
        :
+       _bytesLoaded(0),
+       _bytesTotal(0),
        _stream(sp.getStream(url, postdata)),
        _completed(false),
        _canceled(false)
@@ -157,6 +158,8 @@ LoadVariablesThread::LoadVariablesThread(const 
StreamProvider& sp,
 LoadVariablesThread::LoadVariablesThread(const StreamProvider& sp,
         const URL& url)
        :
+       _bytesLoaded(0),
+       _bytesTotal(0),
        _stream(sp.getStream(url)),
        _completed(false),
        _canceled(false)
diff --git a/libcore/LoadVariablesThread.h b/libcore/LoadVariablesThread.h
index c262152..633fdeb 100644
--- a/libcore/LoadVariablesThread.h
+++ b/libcore/LoadVariablesThread.h
@@ -21,21 +21,15 @@
 #ifndef GNASH_LOADVARIABLESTHREAD_H
 #define GNASH_LOADVARIABLESTHREAD_H
 
-#include "StreamProvider.h" // for inlines
-#include "URL.h" // for inlines
-
-
 #include <string>
 #include <map>
-#include <memory>
+#include <boost/scoped_ptr.hpp>
 #include <boost/thread/thread.hpp>
 #include <boost/thread/mutex.hpp>
 #include <boost/bind.hpp> 
 
-// Forward declarations
-namespace gnash {
-       //class URL;
-}
+#include "StreamProvider.h" // for inlines
+#include "URL.h" // for inlines
 
 namespace gnash {
 
@@ -198,9 +192,9 @@ private:
 
        size_t _bytesTotal;
 
-       std::auto_ptr<IOChannel> _stream;
+    boost::scoped_ptr<IOChannel> _stream;
 
-       std::auto_ptr<boost::thread> _thread;
+    boost::scoped_ptr<boost::thread> _thread;
 
        ValuesMap _vals;
 

http://git.savannah.gnu.org/cgit//commit/?id=c2cb4a6db92ebb459f5475f935a685e21b982fb4


commit c2cb4a6db92ebb459f5475f935a685e21b982fb4
Author: Benjamin Wolsey <address@hidden>
Date:   Mon Apr 4 10:07:55 2011 +0200

    Pass by reference (cppcheck warning).

diff --git a/libcore/vm/SafeStack.h b/libcore/vm/SafeStack.h
index 7b5d621..27ec6f4 100644
--- a/libcore/vm/SafeStack.h
+++ b/libcore/vm/SafeStack.h
@@ -124,30 +124,26 @@ public:
        /// Shrink the stack by i entries. Does not invalidate any entries
        /// previously given, it just sets the top for pop, push, and top
        /// operations.
-       void drop(StackSize i)
-    {
+       void drop(StackSize i) {
         if (i > size()) throw StackException();
         _end -= i;
     }
 
        /// Drop all stack elements reguardless of the "downstop"
-       void clear()
-       {
+       void clear() {
         _downstop = 0;
         _end = 1;
     }
 
        /// Put a new value onto the top of the stack.  The value will be
        /// copied.
-       void push(const T t)
-       {
+       void push(const T& t) {
         grow(1);
         top(0) = t;
     }
 
        /// Pop the top of the stack.
-       T& pop()
-       {
+       T& pop() {
         T& ret = top(0);
         drop(1);
         return ret;

http://git.savannah.gnu.org/cgit//commit/?id=c97c959440134fb07dcc2ce884aee487ce417ba9


commit c97c959440134fb07dcc2ce884aee487ce417ba9
Author: Benjamin Wolsey <address@hidden>
Date:   Mon Apr 4 10:07:42 2011 +0200

    Fix more cppcheck warnings.

diff --git a/libcore/MovieClip.cpp b/libcore/MovieClip.cpp
index a8f8b16..51a8dea 100644
--- a/libcore/MovieClip.cpp
+++ b/libcore/MovieClip.cpp
@@ -601,7 +601,7 @@ MovieClip::call_frame_actions(const as_value& frame_spec)
     if (playlist) {
         PlayList::const_iterator it = playlist->begin();
         const PlayList::const_iterator e = playlist->end();
-        for (; it != e; it++) {
+        for (; it != e; ++it) {
             (*it)->executeActions(this, _displayList);
         }
     }
diff --git a/libcore/asobj/XMLNode_as.cpp b/libcore/asobj/XMLNode_as.cpp
index 11d3df6..32a90f1 100644
--- a/libcore/asobj/XMLNode_as.cpp
+++ b/libcore/asobj/XMLNode_as.cpp
@@ -250,7 +250,7 @@ XMLNode_as::previousSibling()
 
     XMLNode_as *previous_node = 0;
     for (Children::iterator itx = _parent->_children.begin();
-            itx != _parent->_children.end(); itx++) {
+            itx != _parent->_children.end(); ++itx) {
 
         if (*itx == this) return previous_node;
                

http://git.savannah.gnu.org/cgit//commit/?id=59b62a00a6a2515ae970c4d996aa29108b40fdd8


commit 59b62a00a6a2515ae970c4d996aa29108b40fdd8
Author: Benjamin Wolsey <address@hidden>
Date:   Mon Apr 4 10:07:15 2011 +0200

    Fix some cppcheck warnings.

diff --git a/libcore/DisplayList.cpp b/libcore/DisplayList.cpp
index 466de50..c9c4536 100644
--- a/libcore/DisplayList.cpp
+++ b/libcore/DisplayList.cpp
@@ -758,7 +758,7 @@ DisplayList::mergeDisplayList(DisplayList& newList)
             // depth in old list is occupied, and empty in new list.
             if (depthOld < depthNew) {
 
-                itOld++;
+                ++itOld;
                 // unload the DisplayObject if it's in static zone(-16384,0)
                 if (depthOld < 0) {
                     _charsByDepth.erase(itOldBackup);
diff --git a/libcore/Geometry.h b/libcore/Geometry.h
index 3ba67f4..014a764 100644
--- a/libcore/Geometry.h
+++ b/libcore/Geometry.h
@@ -460,7 +460,7 @@ public:
     {
         mat.transform(ap);
         std::vector<Edge>::iterator it = m_edges.begin(), ie = m_edges.end();
-        for(; it != ie; it++)
+        for(; it != ie; ++it)
         {
             (*it).transform(mat);
         }

http://git.savannah.gnu.org/cgit//commit/?id=71d53053a878796a1610eeb7d2024e7a0e3e0044


commit 71d53053a878796a1610eeb7d2024e7a0e3e0044
Author: Benjamin Wolsey <address@hidden>
Date:   Mon Apr 4 09:42:08 2011 +0200

    Initialize member in copy ctor.

diff --git a/libbase/RTMP.cpp b/libbase/RTMP.cpp
index 30adb28..f9cba5f 100644
--- a/libbase/RTMP.cpp
+++ b/libbase/RTMP.cpp
@@ -134,7 +134,8 @@ RTMPPacket::RTMPPacket(size_t reserve)
 RTMPPacket::RTMPPacket(const RTMPPacket& other)
     :
     header(other.header),
-    buffer(other.buffer)
+    buffer(other.buffer),
+    bytesRead(other.bytesRead)
 {}
 
 const size_t RTMPHeader::headerSize;

http://git.savannah.gnu.org/cgit//commit/?id=cb7cfaf5c404744838a26e43f9fd9692310199c6


commit cb7cfaf5c404744838a26e43f9fd9692310199c6
Author: Benjamin Wolsey <address@hidden>
Date:   Mon Apr 4 09:41:58 2011 +0200

    Include order.

diff --git a/libbase/Socket.cpp b/libbase/Socket.cpp
index 18b5eac..b6153bb 100644
--- a/libbase/Socket.cpp
+++ b/libbase/Socket.cpp
@@ -18,21 +18,17 @@
 // Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA  02110-1301  USA
 //
 
-#include <boost/cstdint.hpp>
-
-namespace {
-}
-            
-#include "GnashSystemNetHeaders.h"
-#include "GnashSystemFDHeaders.h"
+#include "Socket.h"
 
 #include <cstring>
 #include <cerrno>
 #include <csignal>
 #include <boost/lexical_cast.hpp>
-
+#include <boost/cstdint.hpp>
+            
+#include "GnashSystemNetHeaders.h"
+#include "GnashSystemFDHeaders.h"
 #include "URL.h"
-#include "Socket.h"
 #include "log.h"
 #include "utility.h"
 #include "GnashAlgorithm.h"

http://git.savannah.gnu.org/cgit//commit/?id=7645643082a893711cfdd6736913f86bd4409da3


commit 7645643082a893711cfdd6736913f86bd4409da3
Author: Benjamin Wolsey <address@hidden>
Date:   Mon Apr 4 09:41:42 2011 +0200

    Initialize member.

diff --git a/libbase/log.h b/libbase/log.h
index 6978f5a..325f8a9 100644
--- a/libbase/log.h
+++ b/libbase/log.h
@@ -391,7 +391,7 @@ class DSOEXPORT HostFunctionReport
 public:
     // Only print function tracing messages when multiple -v
     // options have been supplied. 
-    HostFunctionReport() {
+    HostFunctionReport() : _func(0) {
         log_debug("entering");
     }
 

-----------------------------------------------------------------------

Summary of changes:
 libbase/RTMP.cpp                      |    3 ++-
 libbase/Socket.cpp                    |   14 +++++---------
 libbase/log.h                         |    2 +-
 libcore/DisplayList.cpp               |    2 +-
 libcore/Geometry.h                    |    2 +-
 libcore/LoadVariablesThread.cpp       |    5 ++++-
 libcore/LoadVariablesThread.h         |   16 +++++-----------
 libcore/MovieClip.cpp                 |    2 +-
 libcore/asobj/XMLNode_as.cpp          |    2 +-
 libcore/parser/SWFMovieDefinition.cpp |    2 ++
 libcore/swf/ScriptLimitsTag.h         |    2 +-
 libcore/vm/SafeStack.h                |   12 ++++--------
 12 files changed, 28 insertions(+), 36 deletions(-)


hooks/post-receive
-- 
Gnash