[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Gnash-commit] [patch #7533] [PATCH] AbcBlock.h: checkBounds should chec

From: Mj Mendoza IV
Subject: [Gnash-commit] [patch #7533] [PATCH] AbcBlock.h: checkBounds should check for negative values
Date: Wed, 27 Apr 2011 03:11:52 +0000
User-agent: Mozilla/5.0 (Windows NT 5.1; rv:2.0) Gecko/20100101 Firefox/4.0

Follow-up Comment #2, patch #7533 (project gnash):

I believe so, but I'm only trying to address a TODO inside
`libcore/vm/Machine.cpp' at line 64:

/// TODO: it's quite possible for a malformed SWF to ask for out-of-bounds
/// pool access, although at the moment it's mainly Gnash bugs causing this.
/// Throwing an exception is good here, but it's not clear which one.

All `pool_{datatype}' are using `try/catch' to address the above TODO. But
each `{datatype}PoolAt' are already using the checkBounds, which is not
checking for negative values.

My suggestion is for `checkBounds' to implement checking of negative values so
these try/catches will be removed.


Reply to this item at:


  Message sent via/by Savannah

reply via email to

[Prev in Thread] Current Thread [Next in Thread]