[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Gnash-commit] [patch #7961] Fix for issues with youtube in NetStream_as

From: Rob Savoye
Subject: [Gnash-commit] [patch #7961] Fix for issues with youtube in NetStream_as.cpp
Date: Fri, 01 Mar 2013 22:08:36 +0000
User-agent: Mozilla/5.0 (X11; Linux i686; rv:18.0) Gecko/20100101 Firefox/18.0

Update of patch #7961 (project gnash):

                  Status:                    Done => In Progress            
             Open/Closed:                  Closed => Open                   


Follow-up Comment #2:

  I dug into the new testsuite failures caused by these last two patches. The
basics of these patches appears correct, but part of the problem is the
support for these isn't implemented in NetStream. For example,
NetStream::getCurrentFPS() is hardcoded to always return 0. There are some
weird behaviours going on as well. Although these are readonly properties, the
current test case tries to set them to both a string and boolean
value, and then expects the return value when the NetStream isn't connected to
be the same as the object it was previous set too. When the test case is run
with the Adobe player, it has this behaviour, so the tests pass. I'm not sure
if that needs to be the same behaviour in Gnash. The support for these new
properties needs to be implemented before most of these tests will pass.


Reply to this item at:


  Message sent via/by Savannah

reply via email to

[Prev in Thread] Current Thread [Next in Thread]