[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Gnash-commit] [SCM] Gnash branch, master, updated. release_0_8_9_fi
|
From: |
Gabriele Giacone |
|
Subject: |
Re: [Gnash-commit] [SCM] Gnash branch, master, updated. release_0_8_9_final-1748-g95c3775 |
|
Date: |
Mon, 19 Aug 2013 16:42:02 +0200 |
On Mon, Aug 19, 2013 at 11:24 AM, Sandro Santilli <address@hidden> wrote:
> Replacing use of a macro with an hardcoded number doesn't sound
> that safe. The point of an external macro is that depending on
> which version of the ffmpeg library you use you can get different
> numbers and you should honour those requests.
>
> I've no idea about how this specific macro may affect usage
> of the library, but generally speaking it sounds unsafe to just
> pretend we know the number.
>
> Did they just change the name of that macro ? We should make our
> macro expand to the correct name of their macro, basically, something
> like:
>
> #ifdef AVCODEC_MAX_AUDIO_FRAME_SIZE
> # define MAX_AUDIO_FRAME_SIZE AVCODEC_MAX_AUDIO_FRAME_SIZE
> #else
> # define MAX_AUDIO_FRAME_SIZE AVCODEC_THE_NEW_NAME ?
> #endif
http://git.videolan.org/?p=ffmpeg.git;a=commitdiff;h=0eea212;hp=560f773c7ddd17f66e2621222980c1359a9027be
It was hardcoded, it's still hardcoded. I thought it was the simplest way,