[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Gnash-commit] [patch #8165] Fix warning: comparison of unsigned express
|
From: |
Sandro Santilli |
|
Subject: |
[Gnash-commit] [patch #8165] Fix warning: comparison of unsigned expression >= 0 is always true |
|
Date: |
Thu, 22 Aug 2013 07:33:44 +0000 |
|
User-agent: |
Mozilla/5.0 (X11; Ubuntu; Linux x86_64; rv:22.0) Gecko/20100101 Firefox/22.0 |
Follow-up Comment #1, patch #8165 (project gnash):
Your patch turns a probing into a full scan. Better reviewed by Bastiaan as I
haven't done GST much (more on the FFMPEG side).
Yes, I do remember there should be no probe, as reported in 8e986fb9, but you
can see that the full scanning is supposed to happen in a separate thread (see
startParserThread later) while this patch makes it in the main thread.
I shall also notice that the FFMPEG MediaParser is doing the probe too.
If the goal is removing the probe I think the correct handling would be
providing a testcase showing that we do NOT NEED probing.
Bug #24371 may help with that.
_______________________________________________________
Reply to this item at:
<http://savannah.gnu.org/patch/?8165>
_______________________________________________
Message sent via/by Savannah
http://savannah.gnu.org/