[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Gnash-commit] [bug #41185] Get rid of warning (unused start varible whe
From: |
Petter Reinholdtsen |
Subject: |
[Gnash-commit] [bug #41185] Get rid of warning (unused start varible when NDEBUG is not defined) |
Date: |
Fri, 10 Jan 2014 12:29:57 +0000 |
User-agent: |
Opera/9.80 (X11; Linux x86_64) Presto/2.12.388 Version/12.16 |
URL:
<http://savannah.gnu.org/bugs/?41185>
Summary: Get rid of warning (unused start varible when NDEBUG
is not defined)
Project: Gnash - The GNU Flash player
Submitted by: pere
Submitted on: Fri 10 Jan 2014 12:29:56 GMT
Category: core
Severity: 3 - Normal
Release: master
Status: None
Privacy: Public
Assigned to: None
Open/Closed: Open
Discussion Lock: Any
_______________________________________________________
Details:
While building gnash for coverity, I saw this warning:
CXX DefineBitsTag.lo
swf/DefineBitsTag.cpp: In function 'gnash::FileType
gnash::SWF::{anonymous}::c\
heckFileType(gna
sh::SWFStream&)':
swf/DefineBitsTag.cpp:301:18: warning: unused variable 'start'
[-Wunused-varia\
ble]
const size_t start = in.tell();
^
This fix should fix the problem:
diff --git a/libcore/swf/DefineBitsTag.cpp b/libcore/swf/DefineBitsTag.cpp
index a7c8b79..9967921 100644
--- a/libcore/swf/DefineBitsTag.cpp
+++ b/libcore/swf/DefineBitsTag.cpp
@@ -297,10 +297,6 @@ readDefineBitsJpeg(SWFStream& /*in*/, movie_definition&
m\
)
FileType
checkFileType(SWFStream& in)
{
-#ifndef NDEBUG
- const size_t start = in.tell();
-#endif
-
const size_t bytes = 3;
char buf[bytes];
--
Happy hacking
Petter Reinholdtsen
_______________________________________________________
Reply to this item at:
<http://savannah.gnu.org/bugs/?41185>
_______________________________________________
Message sent via/by Savannah
http://savannah.gnu.org/
- [Gnash-commit] [bug #41185] Get rid of warning (unused start varible when NDEBUG is not defined),
Petter Reinholdtsen <=