[Gnash-commit] [SCM] Gnash branch, master, updated. release_0_8_9_final-1835-gb69f91e

[Petter Reinholdtsen]

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "Gnash".

The branch, master has been updated
       via  b69f91e6d3182c6feaddc18403597938bf5626c9 (commit)
      from  45167dc457c52d29dcbe134a78d4dc6153d3529b (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
http://git.savannah.gnu.org/cgit//commit/?id=b69f91e6d3182c6feaddc18403597938bf5626c9


commit b69f91e6d3182c6feaddc18403597938bf5626c9
Author: Petter Reinholdtsen <address@hidden>
Date:   Wed Jan 15 11:54:37 2014 +0100

    Tell Coverity and the casual reader that some switch block fall
    through cases are intentional. This addreses these Coverity CIDs:
    
     1154665 (libcore/asobj/TextFormat_as.cpp)
     1154664 (libcore/asobj/Date_as.cpp)
     1154663 (libcore/asobj/Date_as.cpp)
     1154662 (libcore/asobj/MovieClip_as.cpp)
     1149157 (libbase/RTMP.cpp)
     1149156 (libbase/RTMP.cpp)

diff --git a/libbase/RTMP.cpp b/libbase/RTMP.cpp
index cc5046f..068fc11 100644
--- a/libbase/RTMP.cpp
+++ b/libbase/RTMP.cpp
@@ -845,16 +845,20 @@ HandShaker::call()
         case 0:
             if (!stage0()) return;
             _stage = 1;
+            /* Fall through */
         case 1:
             if (!stage1()) return;
             _stage = 2;
+            /* Fall through */
         case 2:
             if (!stage2()) return;
             _stage = 3;
+            /* Fall through */
         case 3:
             if (!stage3()) return;
             log_debug("Handshake completed");
             _complete = true;
+           break;
     }
 }
 
diff --git a/libcore/asobj/Date_as.cpp b/libcore/asobj/Date_as.cpp
index 4b856e2..ee5d12b 100644
--- a/libcore/asobj/Date_as.cpp
+++ b/libcore/asobj/Date_as.cpp
@@ -463,6 +463,7 @@ date_new(const fn_call& fn)
                 log_aserror(_("Date constructor called with more than 7 "
                         "arguments"));
                 )
+                /* Fall through */
             case 7:
                 // fractions of milliseconds are ignored
                 gt.millisecond = toInt(fn.arg(6), getVM(fn));
@@ -1250,6 +1251,7 @@ date_UTC(const fn_call& fn) {
             IF_VERBOSE_ASCODING_ERRORS(
                 log_aserror(_("Date.UTC was called with more than 7 
arguments"));
             )
+            /* Fall through */
         case 7:
             // millisecs is double, but fractions of millisecs are ignored.
             gt.millisecond = toInt(fn.arg(6), getVM(fn));
diff --git a/libcore/asobj/MovieClip_as.cpp b/libcore/asobj/MovieClip_as.cpp
index 087182a..3b8c0f4 100644
--- a/libcore/asobj/MovieClip_as.cpp
+++ b/libcore/asobj/MovieClip_as.cpp
@@ -1118,6 +1118,7 @@ movieclip_getURL(const fn_call& fn)
                     "dropped"), os.str());
             );
         }
+            /* Fall through */
         case 3:
             // This argument has already been handled.
         case 2:
diff --git a/libcore/asobj/TextFormat_as.cpp b/libcore/asobj/TextFormat_as.cpp
index 7d1e60c..c09e5bb 100644
--- a/libcore/asobj/TextFormat_as.cpp
+++ b/libcore/asobj/TextFormat_as.cpp
@@ -406,6 +406,7 @@ textformat_new(const fn_call& fn)
        {
            default:
                log_error(_("Too many args (%d) passed to TextFormat"), args);
+               /* Fall through */
            case 13:
                tf->leadingSet(pixelsToTwips(toInt(fn.arg(12), getVM(fn))));
            case 12:

-----------------------------------------------------------------------

Summary of changes:
 libbase/RTMP.cpp                |    4 ++++
 libcore/asobj/Date_as.cpp       |    2 ++
 libcore/asobj/MovieClip_as.cpp  |    1 +
 libcore/asobj/TextFormat_as.cpp |    1 +
 4 files changed, 8 insertions(+), 0 deletions(-)


hooks/post-receive
-- 
Gnash