[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Gnash-commit] [SCM] Gnash branch, master, updated. release_0_8_9_fi

From: Bastiaan Jacques
Subject: Re: [Gnash-commit] [SCM] Gnash branch, master, updated. release_0_8_9_final-2104-g0c13c8e
Date: Mon, 9 Jun 2014 16:56:34 +0200 (CEST)
User-agent: Alpine 2.00 (DEB 1167 2008-08-23)

On Wed, 4 Jun 2014, Richard Wilbur wrote:
Looks like a good set of changes.  I noticed a couple inconsistencies
that I thought I would point out.

diff --git a/libcore/asobj/NetConnection_
as.cpp b/libcore/asobj/NetConnection_as.cpp
index 7a2e7df..e6c7895 100644
@@ -234,10 +234,10 @@ public:
     /// @param nc   The NetConnection AS object to send status/error events to
     /// @param url  URL to post calls to
-    HTTPConnection(NetConnection_as& nc, const URL& url)
+    HTTPConnection(NetConnection_as& nc, const URL url)

Looks suspiciously like the 'const' survived the cut?


+        unsigned long ms, fn_call::Args args, bool runOnce)
    _start(std::numeric_limits<unsigned long>::max()),

In the second Timer constructor, looks like methodName got the
constructor parameter treatment, but missed the std::move() treatment.

Well spotted, thanks!


reply via email to

[Prev in Thread] Current Thread [Next in Thread]