[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Gnash-commit] [SCM] Gnash branch, master, updated. release_0_8_9_fi

From: Sandro Santilli
Subject: Re: [Gnash-commit] [SCM] Gnash branch, master, updated. release_0_8_9_final-2138-ga9f7f74
Date: Thu, 26 Jun 2014 10:12:39 +0200
User-agent: Mutt/1.5.21 (2010-09-15)

On Wed, Jun 25, 2014 at 08:31:56PM -0600, Richard Wilbur wrote:
> On Wed, Jun 25, 2014 at 4:02 PM, Bastiaan Jacques <address@hidden> wrote:
> > On Tue, 24 Jun 2014, Richard Wilbur wrote:
> >
> >> How do I submit patches?  Or am I misunderstanding the process for
> >> gnash?  Should I commit to my local tree and then use a particular git
> >> command to send the contents of the commit to this list?
> >
> >
> > Yes, if you do it that way, then your commit information (such as the
> > author and description) will be retained when it's applied to master.
> >
> > You could use git format-patch and email the result. Patches can also be
> > submitted using Savannah's patch tracker.
> I believe the last time I contributed a patch, gnash was still using
> bzr for version control.  I admit to considerably more experience
> using bzr than git for version control.
> So which is the preferred method for submitting changes?
> 1.  git format-patch and email the result to address@hidden

gnash-commit list would actually only be for reviews of committed
code. The development list is gnash-dev

> or
> 2.  submit patch to Savannah's patch tracker

I'd think savannah tracker is to be preferred so that the commit log
can reference the ticket where more info/discussion can eventually
be found (in a future archeological research :)

That's assuming you handle to write a reference to the ticket from
the commit, which means doing it in 3 steps:

   - Create the ticket, obtaining ticket number
   - Commit with log, referencing ticket number
   - Attach the patch to the ticket

But this is just how I generally try to contribute to "open development"
projects, not anything "normative" :)


reply via email to

[Prev in Thread] Current Thread [Next in Thread]