[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Gnash-commit] [bug #46607] Embedded audio quality degradation

From: Sandro Santilli
Subject: [Gnash-commit] [bug #46607] Embedded audio quality degradation
Date: Tue, 08 Dec 2015 11:24:24 +0000
User-agent: Mozilla/5.0 (X11; Ubuntu; Linux x86_64; rv:42.0) Gecko/20100101 Firefox/42.0

Follow-up Comment #13, bug #46607 (project gnash):

I've looked closely at bastiann code and found the problem being in the
LiveSound::consumeInput function. I have a patch that fixes that
implementation so we might go back to the new implementation, but would like a
review from Bastiaan.

The patch applies to the code before the revert.
I'm attaching it here (consumeInput.patch).

Basically the "delaySeek" value is larger than the size of he first buffer, so
setting _consumed to the requested size is incorrect, and leaves _pos in a
wrong state.

Bastiaan, if you think the new code is worth it, I'd revert the revert and
apply this patch. I dunno if you run performance tests to check how the new
code compared to the old...

(file #35661)

Additional Item Attachment:

File name: consumeInput.patch             Size:0 KB


Reply to this item at:


  Message sent via/by Savannah

reply via email to

[Prev in Thread] Current Thread [Next in Thread]