[Gnash-commit] [patch #8851] Patch to make `GetVariable()` plugin function use SWF version-specific string conversion

[Nutchanon Wetchasit]

URL:
  <http://savannah.gnu.org/patch/?8851>

                 Summary: Patch to make `GetVariable()` plugin function use
SWF version-specific string conversion
                 Project: Gnash - The GNU Flash player
            Submitted by: nachanon
            Submitted on: Mon 11 Jan 2016 10:00:28 PM ICT
                Category: core
                Priority: 5 - Normal
                  Status: None
                 Privacy: Public
             Assigned to: None
        Originator Email: 
             Open/Closed: Open
         Discussion Lock: Any

    _______________________________________________________

Details:

Currently, Gnash's implementation of `GetVariable()` plugin interface uses
variable-to-string conversion function
<http://git.savannah.gnu.org/cgit/gnash.git/tree/libcore/movie_root.cpp?id=15d61a804138737764689338c491c41f2cf59acf#n1605>
that is based on SWF7 convention
<http://git.savannah.gnu.org/cgit/gnash.git/tree/libcore/as_value.h?id=15d61a804138737764689338c491c41f2cf59acf#n236>
which causes discrepancy when the variable in question has `undefined` value
and root SWF is _version *6* or below_
<https://savannah.gnu.org/bugs/?46719#comment2> (it gives a string "undefined"
instead of
the expected empty string).

This patch makes it use a correct string conversion convention according to
root movie's SWF version, and adjusts the relevant automated test
accordingly;
fixing bug #46719, unblocking automated check of bug #45840 under SWF5.

See the attached `0001_getvariable-use-correct-string-conversion.patch`. 

Gnash: 0.8.11dev (patched against git 15d61a8 26-Dec-2015)
Flash Player: 11.2 r202 (11.2.202.491) NPAPI binary
Browser: Iceweasel 10.0.12 (debian)
System: Debian GNU/Linux 7.0 Wheezy i386



    _______________________________________________________

File Attachments:


-------------------------------------------------------
Date: Mon 11 Jan 2016 10:00:28 PM ICT  Name:
0001_getvariable-use-correct-string-conversion.patch  Size: 3kB   By: nachanon
Patch to make `GetVariable()` plugin function use SWF version-specific string
conversion
<http://savannah.gnu.org/patch/download.php?file_id=35991>

    _______________________________________________________

Reply to this item at:

  <http://savannah.gnu.org/patch/?8851>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.gnu.org/