[Gnash-commit] [patch #8858] Patch to avoid freeze when SWF caused gtk-gnash to exit on first frame

[Nutchanon Wetchasit]

URL:
  <http://savannah.gnu.org/patch/?8858>

                 Summary: Patch to avoid freeze when SWF caused gtk-gnash to
exit on first frame
                 Project: Gnash - The GNU Flash player
            Submitted by: nachanon
            Submitted on: Thu 14 Jan 2016 10:54:06 PM ICT
                Category: gui
                Priority: 5 - Normal
                  Status: None
                 Privacy: Public
             Assigned to: None
        Originator Email: 
             Open/Closed: Open
         Discussion Lock: Any

    _______________________________________________________

Details:

Patch 1 of 2:
See the attached `0001_avoid-gtk-main-if-first-frame-exit.patch`.

Current Gnash's GTK GUI implementation have a problem when the rendering
of SWF finished _in first frame_ (whether this is due to `fscommand("quit")`
code or using `--once` option with single-frame SWF), it will result in Gnash
freezing instead of exiting normally
<https://savannah.gnu.org/bugs/?27981#comment2>.

This is caused by gtk-gnash's `GtkGui::quitUI()` which tried to call
`gtk_main_quit()` before the `gtk_main()` loop was entered in `GtkGui::run()`
<https://savannah.gnu.org/bugs/?27981#comment4>.
So when the GTK main loop was run, it didn't stop.

The patch addressed this by:
* Making `GtkGui:quitUI()` call `gtk_main_quit()` only when GTK main loop is
running.
* Making `GtkGui:quitUI()` set an `_exiting` flag in `GtkGui`.
* Making `GtkGui::run()` skip calling `gtk_main()` if `_exiting` flag in
`GtkGui` is set.

This fixes bug #46308 and freezing part of bug #27981;
window-related assertion warnings part of bug #27981 still remains.

Might need a review since I'm not sure if there is a nicer way to do this.

Gnash: 0.8.11dev (patched against git e8b111c 13-Jan-2016)
System: Debian GNU/Linux 7.0 Wheezy i386




    _______________________________________________________

File Attachments:


-------------------------------------------------------
Date: Thu 14 Jan 2016 10:54:06 PM ICT  Name:
0001_avoid-gtk-main-if-first-frame-exit.patch  Size: 1kB   By: nachanon
Patch to make `GtkGui::run()` avoid entering `gtk_main() if an exit was
pending
<http://savannah.gnu.org/patch/download.php?file_id=36033>

    _______________________________________________________

Reply to this item at:

  <http://savannah.gnu.org/patch/?8858>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.gnu.org/