[Gnash-commit] [patch #8887] Patch to correct text console restoration in `fb-gnash`

[Nutchanon Wetchasit]

Follow-up Comment #3, patch #8887 (project gnash):

Patch 3 of 3:
See the attached `0003_remove-fd-variable-check-in-fb-gnash.patch`.

Current Gnash's `FBGui` class's destructor decides whether if would try to
call terminal cleanup code by looking at `FBGui::_fd` variable's validity
<http://git.savannah.gnu.org/cgit/gnash.git/tree/gui/fb/fb.cpp?id=62cfdfe81d6d9a17c722558dc6046b6596342e98#n177>.

But in current code, function `disable_terminal()`
<http://git.savannah.gnu.org/cgit/gnash.git/tree/gui/fb/fb.cpp?id=62cfdfe81d6d9a17c722558dc6046b6596342e98#n555>,
and `enable_terminal()`
<http://git.savannah.gnu.org/cgit/gnash.git/tree/gui/fb/fb.cpp?id=62cfdfe81d6d9a17c722558dc6046b6596342e98#n687>
or any other function in `FBGui` didn't really do anything meaningful with
the
variable. Therefore, it was left it in `-1` value, preventing the call to
console cleanup code.

This patch removes the fd check in destructor, making the console cleanup
code always run at exit; and also removes the variable entirely, as it is
not used anymore, correcting wrong code of `disable_terminal()`
<http://git.savannah.gnu.org/cgit/gnash.git/tree/gui/fb/fb.cpp?id=62cfdfe81d6d9a17c722558dc6046b6596342e98#n615>
in the process;
completing the fix of main issue in bug #46949.

Gnash: 0.8.11dev (patched against git 62cfdfe 16-Jan-2016)
Framebuffer: inteldrmfb `/dev/fb0` 1366x768 32-bit RGBA
System: Debian GNU/Linux 7.0 Wheezy i386


(file #36147)
    _______________________________________________________

Additional Item Attachment:

File name: 0003_remove-fd-variable-check-in-fb-gnash.patch Size:1 KB


    _______________________________________________________

Reply to this item at:

  <http://savannah.gnu.org/patch/?8887>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.gnu.org/