[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Gnash-commit] [patch #8887] Patch to correct text console restoration i

From: Nutchanon Wetchasit
Subject: [Gnash-commit] [patch #8887] Patch to correct text console restoration in `fb-gnash`
Date: Sat, 23 Jan 2016 13:35:49 +0000
User-agent: Mozilla/5.0 (X11; Linux i686; rv:25.5) Gecko/20150606 Firefox/31.9 PaleMoon/25.5.0

Follow-up Comment #3, patch #8887 (project gnash):

Patch 3 of 3:
See the attached `0003_remove-fd-variable-check-in-fb-gnash.patch`.

Current Gnash's `FBGui` class's destructor decides whether if would try to
call terminal cleanup code by looking at `FBGui::_fd` variable's validity

But in current code, function `disable_terminal()`
and `enable_terminal()`
or any other function in `FBGui` didn't really do anything meaningful with
variable. Therefore, it was left it in `-1` value, preventing the call to
console cleanup code.

This patch removes the fd check in destructor, making the console cleanup
code always run at exit; and also removes the variable entirely, as it is
not used anymore, correcting wrong code of `disable_terminal()`
in the process;
completing the fix of main issue in bug #46949.

Gnash: 0.8.11dev (patched against git 62cfdfe 16-Jan-2016)
Framebuffer: inteldrmfb `/dev/fb0` 1366x768 32-bit RGBA
System: Debian GNU/Linux 7.0 Wheezy i386

(file #36147)

Additional Item Attachment:

File name: 0003_remove-fd-variable-check-in-fb-gnash.patch Size:1 KB


Reply to this item at:


  Message sent via/by Savannah

reply via email to

[Prev in Thread] Current Thread [Next in Thread]