[Gnash-commit] [patch #8853] Patch to allow calling zero-argument JavaScript function via `ExternalInterface.call()`

[Nutchanon Wetchasit]

Follow-up Comment #3, patch #8853 (project gnash):

Patch 2 of 2:
See the attached
`0002_add-single-argument-externalinterface-call-test.patch`.

This patch adds a simple Flash-calls-JavaScript ExternalInterface test,
featuring a zero-argument string-returning JavaScript function call,
which ActionScript invokes `ExternalInterface.call()` using single argument.

The test is added as a part of `extcommtests-runner`.

*Note:*
The 1-sec pause between writing return value from container-side
`js_simple()` and writing invoke command to player-side `script_call()`,
is put there to avoid the condition that these two written data block got
read by Gnash as a single-block return value from `js_simple()`; discarding
the `script_call()` invoke, failing the test. This was due to Gnash (player)
used read block boundary to delimit the data
<http://git.savannah.gnu.org/cgit/gnash.git/tree/libcore/ExternalInterface.cpp?id=62cfdfe81d6d9a17c722558dc6046b6596342e98#n361>
rather than the XML tag.

Without a pause, test failures are very likely to appear, especially
under nested `make check-DEJAGNU`, but not when `extcommtests-runner` is run
directly.

Gnash: 0.8.11dev (patched against git 62cfdfe 16-Jan-2016)
System: Debian GNU/Linux 7.0 Wheezy i386


(file #36154)
    _______________________________________________________

Additional Item Attachment:

File name: 0002_add-single-argument-externalinterface-call-test.patch Size:3
KB


    _______________________________________________________

Reply to this item at:

  <http://savannah.gnu.org/patch/?8853>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.gnu.org/