[Gnash-commit] [SCM] Gnash branch, master, updated. release_0_8_9_final-2254-ge705394

[Sandro Santilli]

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "Gnash".

The branch, master has been updated
       via  e705394a72888a8791497d94a7cf4c78b2e23f02 (commit)
      from  b6666a67ff2ab161f73fadd9c17b75573751e41c (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
http://git.savannah.gnu.org/cgit//commit/?id=e705394a72888a8791497d94a7cf4c78b2e23f02


commit e705394a72888a8791497d94a7cf4c78b2e23f02
Author: Nutchanon Wetchasit <address@hidden>
Date:   Fri Jan 29 08:25:58 2016 +0100

    Add automated test for single-argument ExternalInterface.call() usage.

diff --git a/testsuite/misc-mtasc.all/extcomm.as 
b/testsuite/misc-mtasc.all/extcomm.as
index 4f455cd..cb8eaf3 100644
--- a/testsuite/misc-mtasc.all/extcomm.as
+++ b/testsuite/misc-mtasc.all/extcomm.as
@@ -1,6 +1,6 @@
 // extcomm.as - Host container communication (ExternalInterface) tests
 //
-//   Copyright (C) 2015 Free Software Foundation, Inc.
+//   Copyright (C) 2015, 2016 Free Software Foundation, Inc.
 //
 // This program is free software; you can redistribute it and/or modify
 // it under the terms of the GNU General Public License as published by
@@ -136,5 +136,9 @@ class ExternalCommTest
                                }
                        )
                );
+
+               // Calling JavaScript function without any argument should give
+               // a correct return value
+               check_equals(ExternalInterface.call("js_simple"), "Correct");
        }
 }
diff --git a/testsuite/misc-mtasc.all/extcommtests-runner.sh 
b/testsuite/misc-mtasc.all/extcommtests-runner.sh
index c71cd6d..6f0d875 100644
--- a/testsuite/misc-mtasc.all/extcommtests-runner.sh
+++ b/testsuite/misc-mtasc.all/extcommtests-runner.sh
@@ -4,7 +4,7 @@
 # extcommtests-runner.sh: container-emulated, automated
 #     ExternalInterface test generator
 # 
-# Copyright (C) 2015 Free Software Foundation, Inc.
+# Copyright (C) 2015, 2016 Free Software Foundation, Inc.
 # 
 # This program is free software; you can redistribute it and/or modify
 # it under the terms of the GNU General Public License as published by
@@ -26,6 +26,8 @@
 # The generated test runner checks Gnash for:
 #  * ExternalInterface.addCallback() issues (bug #37223)
 #        <https://savannah.gnu.org/bugs/?37223>
+#  * Single-argument ExternalInterface.call() issue (bug #46878)
+#        <https://savannah.gnu.org/bugs/?46878>
 # 
 # Usage:
 #     ./extcommtests-runner.sh <builddir> <srcdir> <swf>
@@ -183,6 +185,20 @@ check_equals \
        '<invoke name="addMethod" 
returntype="xml"><arguments><string>script_longarglist</string></arguments></invoke>'
 \
        "Gnash should properly register script_longarglist ExternalInterface 
callback"
 
+# Read for js_simple JavaScript function invocation statement
+read_timeout LINE \$READTIMEOUT <&3
+check_equals \
+       "\$LINE" \
+       '<invoke name="js_simple" 
returntype="xml"><arguments><string>js_simple</string></arguments></invoke>' \
+       "Gnash should call JavaScript's js_simple function correctly"
+
+# Return string value from js_simple function
+echo '<string>Correct</string>' >&4
+
+# Pause a bit, so the next script_call invoke doesn't get mixed up with
+# the previous return value data
+sleep 1
+
 # Call the script_call callback
 echo '<invoke name="script_call" 
returntype="xml"><arguments><string>Hello</string><string>World</string></arguments></invoke>'
 >&4
 
@@ -244,7 +260,7 @@ XFAILED=\`expr "\$XFAILED" + "\$PLAYERXFAILED"\`
 TESTED=\`expr "\$TESTED" + "\$PLAYERPASSED" + "\$PLAYERXPASSED" + 
"\$PLAYERFAILED" + "\$PLAYERXFAILED"\`
 
 # Check for total number of test run
-check_totals "45" "There should be 45 tests run"
+check_totals "47" "There should be 47 tests run"
 
 # Remove temporary files
 rm "\$LOGFILE"

-----------------------------------------------------------------------

Summary of changes:
 testsuite/misc-mtasc.all/extcomm.as             |    6 +++++-
 testsuite/misc-mtasc.all/extcommtests-runner.sh |   20 ++++++++++++++++++--
 2 files changed, 23 insertions(+), 3 deletions(-)


hooks/post-receive
-- 
Gnash