[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Gnash-commit] [patch #8993] Patches to fix problems when `--disable-med

From: Sandro Santilli
Subject: [Gnash-commit] [patch #8993] Patches to fix problems when `--disable-media` configure option was used
Date: Mon, 9 May 2016 12:07:04 +0000 (UTC)
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:29.0) Gecko/20100101 Firefox/29.0

Follow-up Comment #5, patch #8993 (project gnash):

Another issue is this warning:

/usr/src/gnash/gnash-head/libcore/asobj/NetStream_as.cpp:198:1: warning: no
return statement in function returning non-void [-Wreturn-type]
which can be fixed with this:

diff --git a/libcore/asobj/NetStream_as.cpp b/libcore/asobj/NetStream_as.cpp
index d500ea0..06dec58 100644
--- a/libcore/asobj/NetStream_as.cpp
+++ b/libcore/asobj/NetStream_as.cpp
@@ -194,6 +194,8 @@ NetStream_as::bufferLength()
 #ifdef USE_MEDIA
     if (_parser.get() == nullptr) return 0;
     return _parser->getBufferLength();
+    return 0;
 #endif  // USE_MEDIA

I checked, and the output operator could probably just remain in
MediaParser.cpp, why did you feel the need to move it ?


Reply to this item at:


  Message sent via/by Savannah

reply via email to

[Prev in Thread] Current Thread [Next in Thread]