[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Gnash-commit] [bug #50174] `make check` failed, due to ming-related lin

From: Nutchanon Wetchasit
Subject: [Gnash-commit] [bug #50174] `make check` failed, due to ming-related link error
Date: Mon, 30 Jan 2017 15:39:14 +0000 (UTC)
User-agent: Mozilla/5.0 (X11; Linux i686; rv:25.8) Gecko/20151123 Firefox/31.9 PaleMoon/25.8.1

Follow-up Comment #7, bug #50174 (project gnash):

Current git version of Gnash testsuite is now compiling successfully and
showing normaml result, thanks.

Configure, build, and test logs are attached for the record, as
``. (Note that 2 test failures are expected in my
configuration, per bug #47906)

Regarding the sed pattern, I actually went with that simple one on my the
first try (s/^0*//), but decided to change it to the submitted one
(s/^0*\(.*.\)$/\1/g) after I realized that the simple one tried to strip
"00000000" into a blank "" instead of single zero "0".

The simplified pattern:

$ echo "12345678" | sed --posix 's/^0*//'
$ echo "00000010" | sed --posix 's/^0*//'
$ echo "00040400" | sed --posix 's/^0*//'
$ echo "00000000" | sed --posix 's/^0*//'


Pattern from the submitted patch:

$ echo "12345678" | sed --posix 's/^0*\(.*.\)$/\1/g'
$ echo "00000010" | sed --posix 's/^0*\(.*.\)$/\1/g'
$ echo "00040400" | sed --posix 's/^0*\(.*.\)$/\1/g'
$ echo "00000000" | sed --posix 's/^0*\(.*.\)$/\1/g'

You would see that the simple pattern _does not handle_ "00000000" correctly,
while the submitted pattern does.

But after testing, this problem turned out not to matter as much as I
originally thought; this is because the configure script actually contain a
check for empty MING_VERSION_CODE and automatically re-assign it with
(Notice that the reassignment and comparisons around there are still using
leading zeroes)

Gnash: 0.8.11dev (git 37044f9 30-Jan-2017)
GCC: 4.7.2-5 (debian)
G++: 4.7.2-5 (debian)
Ming: 0.4.4-1.1 (debian)
System: Debian GNU/Linux 7.0 Wheezy i386

(file #39611)

Additional Item Attachment:

File name:      Size:60 KB


Reply to this item at:


  Message sent via/by Savannah

reply via email to

[Prev in Thread] Current Thread [Next in Thread]