[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Gnash-commit] [patch #9279] Patch to fix wrong behavior in getURL()/Mov

From: Nutchanon Wetchasit
Subject: [Gnash-commit] [patch #9279] Patch to fix wrong behavior in getURL()/MovieClip.getURL() on `undefined` and `null` target
Date: Sun, 5 Mar 2017 07:06:59 -0500 (EST)
User-agent: Opera/9.80 (Windows NT 5.1; U; en) Presto/2.10.229 Version/11.64

Follow-up Comment #5, patch #9279 (project gnash):

Patch 6 of 6:
See the attached `0006_geturl-add-weird-target-tests.patch`.

This patch adds automated checks non-FSCommand usage of `getURL()` and
`MovieClip.getURL()` when encountered with weird target parameter like empty
"", `null`, and `undefined` to Gnash testsuite; according to reference
behavior listed on bug #50393 comment 1

Implementation notes:

* This test is based on MakeSWF, and run under shell-based container emulation
environment, with external termination (much like the `hostcmd` test).
* This test runs on SWF version 4 to 8 as `getURL()` is available since Flash
4 onward- according to Macromedia's documentation.
* I implemented this as a separate test runner from `hostcmd` as it cannot be
run under the same HTML-mode container.
* There's no XFAILED check, as problems are already fixed by earlier
<> patches

This patch does not provide HTML-based test runner, as it is beyond limit of
what simple semi-automated HTML test page could do. Also, implementing the
test even in semi-automated fashion would require another exotic Flash feature
(FlashVars), which must be tested first.

Gnash: 0.8.11dev (patched against git 144e082 22-Feb-2017)
System: Debian GNU/Linux 7.0 Wheezy i386

(file #39894)

Additional Item Attachment:

File name: 0006_geturl-add-weird-target-tests.patch Size:15 KB


Reply to this item at:


  Message sent via/by Savannah

reply via email to

[Prev in Thread] Current Thread [Next in Thread]