[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Gnash-dev] [PATCH] Expand grayscale JPEG data to RGB

From: Bastiaan Jacques
Subject: Re: [Gnash-dev] [PATCH] Expand grayscale JPEG data to RGB
Date: Tue, 25 Apr 2006 19:40:14 +0200
User-agent: KMail/1.9.1

On Tuesday 25 April 2006 16:45, Rob Savoye wrote:
> Without this patch a grayscale jpeg doesn't get read in correctly,
> which has the text display in weird colors, and the layout geometry of
> the movie is all wrong. So I just checked this in.

Well, that takes care of the "what", but not the "why". If I had to guess, I'd 
say that our image rendering engine wasn't designed for grayscale image data. 
If that were the case, I'd prefer to fix the engine rather than the 
conversion this patch adds.

But I could be completely wrong here. In any case, the patch fixes the 
immediate problem.

I do have one nit to pick: since we are changing the color space to RGB, 
should we not also change the m_cinfo.out_color_space field to JCS_RGB?


reply via email to

[Prev in Thread] Current Thread [Next in Thread]