[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Gnash-dev] [PATCH] Initial implementation of a cairo renderer

From: Bastiaan Jacques
Subject: Re: [Gnash-dev] [PATCH] Initial implementation of a cairo renderer
Date: Tue, 02 May 2006 23:04:47 +0200
User-agent: KMail/1.9.1

On Tuesday 02 May 2006 09:45, Timothy Lee wrote:
>     m_texture_id = (unsigned int)cairo_pattern_create_for_surface(m_image);

This is a cast from a pointer to 32-bit integer, which is 64-bit unsafe. I've 
added an m_pattern member to replace m_texture_id.

I've added a configure option --enable-renderer=[renderer], where renderer is 
either opengl or cairo (the default is still opengl).

This work increases the importance of a cleanup of gnash.cpp (which is already 
underway in the form of a frontend library) - when the cairo backend is 
enabled, currently two windows are created. Fixing that is nontrivial due to 
the goop in gnash.cpp.


reply via email to

[Prev in Thread] Current Thread [Next in Thread]