[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Gnash-dev] Re: DEBUG_STACK

From: Rob Savoye
Subject: Re: [Gnash-dev] Re: DEBUG_STACK
Date: Tue, 25 Jul 2006 08:09:12 -0600
User-agent: Thunderbird 1.5 (X11/20051201)

strk wrote:

> Ok, I took a close look. Actually, in the stack dump case we're
> filling a stringstream and *then* passing it to log_action.

  Ah, then we probably need to check the verbose flags before formating.
stringstream isn't real fast, but most people don't dump the action
debug messages when playing movies.

>       log_action("%s", function_returning_string());
> will always execute 'function_returning_string()', even w/out -v specified.

  The old debug macros were changed to functions when I made the conversion.

> do any better ? Or is a C-style macro our only chance ?
> I liked the C-style macro even to be able to completely drop
> debugging at compile time.

  We should be able to do that with the C++ debug support too. I
personally dislike using printf() debug stuff in a C++ program. Now I'd
argue at this point Gnash is full of extraneous debug messages anyway.
:-) But I'd prefer to stick to a C++ oriented debug log, and also
improve the performance by not executing code unnecessarily.

        - rob -

reply via email to

[Prev in Thread] Current Thread [Next in Thread]