[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Gnash-dev] Logging code
From: |
Rob Savoye |
Subject: |
Re: [Gnash-dev] Logging code |
Date: |
Mon, 07 Aug 2006 13:42:00 -0600 |
User-agent: |
Thunderbird 1.5.0.4 (X11/20060614) |
strk wrote:
> I think wrapping into IF_VERBOSE_WHAT() macro can be a good
> first step, then we'll switch to C++ style calls.
> Before proceeding it's worth cleanly define these macros.
Yep. This is a good case for thinking out the best solution.
> For log_msg, log_action and log_processing we might reintroduce
> in order: IF_VERBOSE, IF_VERBOSE_ACTION, IF_VERBOSE_PARSE.
You mean something like this ?
IF_VERBOSE(log_warning("ARG! it failed!: %s", sterrror(errno)));
or
IF_VERBOSE(dbglogfile << ARG! it failed!: " << terrror(errno) << endl;)
Since log_msg, et al. all use the same underlying infrastructure as
dbglogfile, we should be able to mix C and C++ style debug logging. I
don't think we need to mandate it one way or another.
> What do you think ?
It's hard to think when you've been staring at hex dumps of RTMP and
AMF network dumps for days... :-)
- rob -