[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Gnash-dev] Vitaly's #ifdef WIN32 checkins from Nov 24th

From: John Gilmore
Subject: [Gnash-dev] Vitaly's #ifdef WIN32 checkins from Nov 24th
Date: Mon, 27 Nov 2006 03:50:27 -0800

Is there somebody on the team who can teach Vitaly Alexeev how to make
gnash code more modular when it doesn't compile on WIN32?  He tends to
patch in #ifdef "hacks", which is great for local testing and
development.  But then he checks them into the main code base, rather
than trying to understand the config scripts and provide a clean fix.

I can hardly blame him -- but perhaps with collaboration the code will
port more easily and we'll all know a bit more about config scripts.
Grepping the sources for "WIN32" will find lots of opportunities to
move WIN32-specific hacks out of mainline code and into the config system.

Thanks folks -- the gnash project is moving along very well and quickly.
It's all due to your efforts.



+/* $Id: extension.cpp,v 1.2 2006/11/24 14:41:39 alexeev Exp $ */
+#if HAVE_DIRENT_H || WIN32==1  // win32 hack
 # include <dirent.h>
 # define NAMLEN(dirent) strlen((dirent)->d_name)

+++ ltdl.c      24 Nov 2006 14:42:21 -0000      1.3
@@ -25,6 +25,19 @@
+// win32 hack
+#if defined(_WIN32) || defined(WIN32)
+#define HAVE_STDLIB_H 1
+#define HAVE_STDIO_H 1
+#define HAVE_STRING_H 1
+#define HAVE_CTYPE_H 1
+#define HAVE_ERRNO_H 1
+#define __WINDOWS__ 1
+#define error_t int
+#define LTDL_OBJDIR ""
 #  include <config.h>



reply via email to

[Prev in Thread] Current Thread [Next in Thread]