[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Gnash-dev] install vs install-plugins && klash

From: strk
Subject: Re: [Gnash-dev] install vs install-plugins && klash
Date: Sun, 18 May 2008 17:05:27 +0200

On Sun, May 18, 2008 at 08:15:18AM -0600, Rob Savoye wrote:
> Russ Nelson wrote:
> >strk points out that install copies files needed for klash:
> >May 15 11:55:40 strk    nelson TODO: decide on policy for 'install' vs. 
> >'install-plugins' (klash data is currently installed on 'install')
> >
> >I think the right thing to do is to only copy data when they say
> >'install-plugins', however I don't want to deal with it on this
> >release since it's a ``prettiness'' and ``consistently'' issue and I'm
> >more concerned about functionality for my first release.
>   The KDE data files should only be installed with the install-plugin 
> target in plugin/klash. I do think though we should make the install 
> target call install-plugins. Gnash worked this way for years, the only 
> reason I created the install-plugins target was to get around an old 
> problem that broke our automated "make distcheck", and I got tired of it 
> failing. The original bug that caused that problem (installation 
> directories that required one to be root), has been fixed for months, so 
> it's not a problem anymore. As most people build Gnash for the plugin, 
> it makes sense to me that install should also install the plugins like 
> we used to do.

The problem is also that 'make distcheck' also tests 'install' and 'uninstall'
rules. So, if we keep defaulting to user dir, by the end of 'make distcheck'
your gnash plugin in user dir will be gone...

Anyway, we use DISTCHECK_CONFIGURE_FLAGS now, to guard against that....


reply via email to

[Prev in Thread] Current Thread [Next in Thread]